Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern ktrop() seems to be expected [by it's callers] to r...



details:   https://anonhg.NetBSD.org/src/rev/86ed0471c0bc
branches:  trunk
changeset: 789992:86ed0471c0bc
user:      martin <martin%NetBSD.org@localhost>
date:      Sat Sep 14 20:20:09 2013 +0000

description:
ktrop() seems to be expected [by it's callers] to return a "bool like"
value, not an errno - make it so.
Remove another unused variable.

diffstat:

 sys/kern/kern_ktrace.c |  8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diffs (43 lines):

diff -r 5444378f5aad -r 86ed0471c0bc sys/kern/kern_ktrace.c
--- a/sys/kern/kern_ktrace.c    Sat Sep 14 17:23:18 2013 +0000
+++ b/sys/kern/kern_ktrace.c    Sat Sep 14 20:20:09 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_ktrace.c,v 1.161 2012/02/19 21:06:51 rmind Exp $  */
+/*     $NetBSD: kern_ktrace.c,v 1.162 2013/09/14 20:20:09 martin Exp $ */
 
 /*-
  * Copyright (c) 2006, 2007, 2008 The NetBSD Foundation, Inc.
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_ktrace.c,v 1.161 2012/02/19 21:06:51 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_ktrace.c,v 1.162 2013/09/14 20:20:09 martin Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1008,7 +1008,6 @@
 int
 ktrace_common(lwp_t *curl, int ops, int facs, int pid, file_t **fpp)
 {
-       struct proc *curp;
        struct proc *p;
        struct pgrp *pg;
        struct ktr_desc *ktd = NULL;
@@ -1017,7 +1016,6 @@
        int error = 0;
        int descend;
 
-       curp = curl->l_proc;
        descend = ops & KTRFLAG_DESCEND;
        facs = facs & ~((unsigned) KTRFAC_PERSISTENT);
 
@@ -1324,7 +1322,7 @@
        mutex_exit(&ktrace_lock);
        mutex_exit(p->p_lock);
 
-       return (1);
+       return error ? 1 : 0;
 }
 
 int



Home | Main Index | Thread Index | Old Index