Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/wsfb Fix bug introduced in rev. 1.69:



details:   https://anonhg.NetBSD.org/src/rev/6c190a0b2cea
branches:  trunk
changeset: 844260:6c190a0b2cea
user:      rin <rin%NetBSD.org@localhost>
date:      Fri Aug 09 17:22:02 2019 +0000

description:
Fix bug introduced in rev. 1.69:
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/wsfb/genfb.c#rev1.69

is_bgr should be initialized to false. Otherwise, color becomes strange
for depths 24 and 32 unless backend explicitly set "is_bgr" property.

diffstat:

 sys/dev/wsfb/genfb.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r 1ee1d0ec53a5 -r 6c190a0b2cea sys/dev/wsfb/genfb.c
--- a/sys/dev/wsfb/genfb.c      Fri Aug 09 12:05:51 2019 +0000
+++ b/sys/dev/wsfb/genfb.c      Fri Aug 09 17:22:02 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: genfb.c,v 1.69 2019/08/07 13:23:12 rin Exp $ */
+/*     $NetBSD: genfb.c,v 1.70 2019/08/09 17:22:02 rin Exp $ */
 
 /*-
  * Copyright (c) 2007 Michael Lorenz
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: genfb.c,v 1.69 2019/08/07 13:23:12 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: genfb.c,v 1.70 2019/08/09 17:22:02 rin Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -569,6 +569,7 @@
        case 24:
                ri->ri_flg |= RI_ENABLE_ALPHA;
 
+               is_bgr = false;
                prop_dictionary_get_bool(device_properties(sc->sc_dev),
                    "is_bgr", &is_bgr);
                if (is_bgr) {



Home | Main Index | Thread Index | Old Index