Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libpthread remove hard-coded -fomit-frame-pointer for pt...



details:   https://anonhg.NetBSD.org/src/rev/76a81f48af2d
branches:  trunk
changeset: 830093:76a81f48af2d
user:      chs <chs%NetBSD.org@localhost>
date:      Sun Feb 25 18:51:18 2018 +0000

description:
remove hard-coded -fomit-frame-pointer for pthread stuff,
let these use the same setting as the rest of the tree.
the performance difference is marginal and this allows
dtrace ustack() to work better.

diffstat:

 lib/libpthread/Makefile |  22 ++--------------------
 1 files changed, 2 insertions(+), 20 deletions(-)

diffs (42 lines):

diff -r 8dea43dd941f -r 76a81f48af2d lib/libpthread/Makefile
--- a/lib/libpthread/Makefile   Sun Feb 25 18:48:39 2018 +0000
+++ b/lib/libpthread/Makefile   Sun Feb 25 18:51:18 2018 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile,v 1.87 2016/07/03 14:24:58 christos Exp $
+#      $NetBSD: Makefile,v 1.88 2018/02/25 18:51:18 chs Exp $
 #
 
 WARNS?=        5
@@ -90,31 +90,13 @@
 
 ALIGN_FUNCTIONS=       ${${ACTIVE_CC} == "gcc":? -falign-functions=32 :}
 
-.if ${MACHINE_CPU} != "m68k" && ${MACHINE_CPU} != "sh3" && ${MACHINE_ARCH} != "vax"
-OMIT_FRAME_POINTER=    -fomit-frame-pointer
-.else
-OMIT_FRAME_POINTER=
-.endif
-
 # The TSD routines are used in the implementation of profiling, and so
 # can't be profiled themselves.
-COPTS.pthread_specific.c+=     ${OMIT_FRAME_POINTER} ${ALIGN_FUNCTIONS}
+COPTS.pthread_specific.c+=     ${ALIGN_FUNCTIONS}
 pthread_specific.po: pthread_specific.o
        ${_MKTARGET_CREATE}
        cp pthread_specific.o pthread_specific.po
 
-# Internal spinlock routines are performance critical.  Don't profile them,
-# it's incompatibile with -fomit-frame-pointer.
-COPTS.pthread_lock.c+= ${OMIT_FRAME_POINTER} ${ALIGN_FUNCTIONS}
-pthread_lock.po: pthread_lock.o
-       ${_MKTARGET_CREATE}
-       cp pthread_lock.o pthread_lock.po
-
-COPTS.pthread_mutex.c+=        ${OMIT_FRAME_POINTER} ${ALIGN_FUNCTIONS}
-pthread_mutex.po: pthread_mutex.o
-       ${_MKTARGET_CREATE}
-       cp pthread_mutex.o pthread_mutex.po
-
 COPTS.pthread.c += -Wno-stack-protector -Wno-format-nonliteral
 COPTS.pthread_attr.c += -Wno-format-nonliteral
 



Home | Main Index | Thread Index | Old Index