Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Set resource limit. The rnd_process_events() functi...



details:   https://anonhg.NetBSD.org/src/rev/3b43d9ef3817
branches:  trunk
changeset: 784048:3b43d9ef3817
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Wed Jan 16 06:45:24 2013 +0000

description:
Set resource limit. The rnd_process_events() function is called every tick
and process the sample queue. Without limitation, if a lot of rnd_add_*()
are called, all kernel memory may be eaten up.

diffstat:

 sys/kern/kern_rndq.c |  16 +++++++++++++---
 1 files changed, 13 insertions(+), 3 deletions(-)

diffs (37 lines):

diff -r ba7c29b0c08e -r 3b43d9ef3817 sys/kern/kern_rndq.c
--- a/sys/kern/kern_rndq.c      Wed Jan 16 06:44:27 2013 +0000
+++ b/sys/kern/kern_rndq.c      Wed Jan 16 06:45:24 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_rndq.c,v 1.6 2012/10/27 01:29:02 tls Exp $        */
+/*     $NetBSD: kern_rndq.c,v 1.7 2013/01/16 06:45:24 msaitoh Exp $    */
 
 /*-
  * Copyright (c) 1997-2011 The NetBSD Foundation, Inc.
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_rndq.c,v 1.6 2012/10/27 01:29:02 tls Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_rndq.c,v 1.7 2013/01/16 06:45:24 msaitoh Exp $");
 
 #include <sys/param.h>
 #include <sys/ioctl.h>
@@ -405,7 +405,17 @@
        rnd_mempc = pool_cache_init(sizeof(rnd_sample_t), 0, 0, 0,
                                    "rndsample", NULL, IPL_VM,
                                    NULL, NULL, NULL);
-       /* Mix *something*, *anything* into the pool to help it get started.
+
+       /*
+        * Set resource limit. The rnd_process_events() function
+        * is called every tick and process the sample queue.
+        * Without limitation, if a lot of rnd_add_*() are called,
+        * all kernel memory may be eaten up.
+        */
+       pool_cache_sethardlimit(rnd_mempc, RND_POOLBITS, NULL, 0);
+
+       /*
+        * Mix *something*, *anything* into the pool to help it get started.
         * However, it's not safe for rnd_counter() to call microtime() yet,
         * so on some platforms we might just end up with zeros anyway.
         * XXX more things to add would be nice.



Home | Main Index | Thread Index | Old Index