Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/ufs/chfs Remove unnecessary assertions



details:   https://anonhg.NetBSD.org/src/rev/71125cf85906
branches:  trunk
changeset: 829633:71125cf85906
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Wed Feb 07 08:50:13 2018 +0000

description:
Remove unnecessary assertions

KASSERT(!rw_lock_held()) just before rw_destroy() is useless because
rw_destroy does more strict check and provides better information on
failure.

diffstat:

 sys/ufs/chfs/ebh.c |  4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diffs (25 lines):

diff -r c5a24cbce27a -r 71125cf85906 sys/ufs/chfs/ebh.c
--- a/sys/ufs/chfs/ebh.c        Wed Feb 07 08:12:25 2018 +0000
+++ b/sys/ufs/chfs/ebh.c        Wed Feb 07 08:50:13 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ebh.c,v 1.6 2015/02/07 04:21:11 christos Exp $ */
+/*     $NetBSD: ebh.c,v 1.7 2018/02/07 08:50:13 ozaki-r Exp $  */
 
 /*-
  * Copyright (c) 2010 Department of Software Engineering,
@@ -656,7 +656,6 @@
        if (le->users == 0) {
                le = RB_REMOVE(ltree_rbtree, &ebh->ltree, le);
                if (le) {
-                       KASSERT(!rw_lock_held(&le->mutex));
                        rw_destroy(&le->mutex);
 
                        kmem_free(le, sizeof(struct chfs_ltree_entry));
@@ -713,7 +712,6 @@
        if (le->users == 0) {
                RB_REMOVE(ltree_rbtree, &ebh->ltree, le);
 
-               KASSERT(!rw_lock_held(&le->mutex));
                rw_destroy(&le->mutex);
 
                kmem_free(le, sizeof(struct chfs_ltree_entry));



Home | Main Index | Thread Index | Old Index