Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/netinet6 Fix a pretty simple, yet pretty tragic typo: we...



details:   https://anonhg.NetBSD.org/src/rev/665ecf9f251f
branches:  trunk
changeset: 829470:665ecf9f251f
user:      maxv <maxv%NetBSD.org@localhost>
date:      Fri Feb 02 06:23:45 2018 +0000

description:
Fix a pretty simple, yet pretty tragic typo: we should return IPPROTO_DONE,
not IPPROTO_NONE. With IPPROTO_NONE we will keep parsing the header chain
on an mbuf that was already freed.

diffstat:

 sys/netinet6/ip6_mroute.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 7c09325b2bfa -r 665ecf9f251f sys/netinet6/ip6_mroute.c
--- a/sys/netinet6/ip6_mroute.c Fri Feb 02 03:41:02 2018 +0000
+++ b/sys/netinet6/ip6_mroute.c Fri Feb 02 06:23:45 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ip6_mroute.c,v 1.119 2017/03/01 08:54:12 ozaki-r Exp $ */
+/*     $NetBSD: ip6_mroute.c,v 1.120 2018/02/02 06:23:45 maxv Exp $    */
 /*     $KAME: ip6_mroute.c,v 1.49 2001/07/25 09:21:18 jinmei Exp $     */
 
 /*
@@ -117,7 +117,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ip6_mroute.c,v 1.119 2017/03/01 08:54:12 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ip6_mroute.c,v 1.120 2018/02/02 06:23:45 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -1886,7 +1886,7 @@
                            (eip6->ip6_vfc & IPV6_VERSION));
 #endif
                        m_freem(m);
-                       return (IPPROTO_NONE);
+                       return (IPPROTO_DONE);
                }
 
                /* verify the inner packet is destined to a mcast group */



Home | Main Index | Thread Index | Old Index