Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-8]: src/sys/arch/mips/mips Pull up following revision(s) (request...



details:   https://anonhg.NetBSD.org/src/rev/706eb154af22
branches:  netbsd-8
changeset: 850701:706eb154af22
user:      martin <martin%NetBSD.org@localhost>
date:      Tue Jun 06 09:25:49 2017 +0000

description:
Pull up following revision(s) (requested by skrll in ticket #10):
        sys/arch/mips/mips/pmap_machdep.c: revision 1.20
Fix the PMAP_NO_PV_UNCACHED pmap_md_vca_add case where the pmap_update
call would cause problems for pmap_remove_all case where the deferred
activate should not be done...
Add a comment about what's going on.

diffstat:

 sys/arch/mips/mips/pmap_machdep.c |  13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diffs (34 lines):

diff -r fa0c2a7b8a3a -r 706eb154af22 sys/arch/mips/mips/pmap_machdep.c
--- a/sys/arch/mips/mips/pmap_machdep.c Tue Jun 06 09:20:14 2017 +0000
+++ b/sys/arch/mips/mips/pmap_machdep.c Tue Jun 06 09:25:49 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pmap_machdep.c,v 1.19 2017/05/18 13:20:37 skrll Exp $  */
+/*     $NetBSD: pmap_machdep.c,v 1.19.2.1 2017/06/06 09:25:49 martin Exp $     */
 
 /*-
  * Copyright (c) 1998, 2001 The NetBSD Foundation, Inc.
@@ -67,7 +67,7 @@
 
 #include <sys/cdefs.h>
 
-__KERNEL_RCSID(0, "$NetBSD: pmap_machdep.c,v 1.19 2017/05/18 13:20:37 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pmap_machdep.c,v 1.19.2.1 2017/06/06 09:25:49 martin Exp $");
 
 /*
  *     Manages physical address maps.
@@ -954,7 +954,14 @@
                pmap_t npm = npv->pv_pmap;
                VM_PAGEMD_PVLIST_UNLOCK(mdpg);
                pmap_remove(npm, nva, nva + PAGE_SIZE);
-               pmap_update(npm);
+
+               /*
+                * pmap_update is not required here as we're the pmap
+                * and we know that the invalidation happened or the
+                * asid has been released (and activation is deferred)
+                *
+                * A deferred activation should NOT occur here.
+                */
                (void)VM_PAGEMD_PVLIST_LOCK(mdpg);
 
                npv = pv;



Home | Main Index | Thread Index | Old Index