[src/trunk]: src/sys/netinet6 Fix use-after-free of mbuf by ip6flow_create

[ozaki-r <ozaki-r%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/3eaf04478519
branches:  trunk
changeset: 828885:3eaf04478519
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Tue Jan 09 04:21:26 2018 +0000

description:
Fix use-after-free of mbuf by ip6flow_create

This fixes recent failures of some ATF tests such as t_ipsec_tunnel_odd.

XXX need pullup-[678]

diffstat:

 sys/netinet6/ip6_forward.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 378c638f551f -r 3eaf04478519 sys/netinet6/ip6_forward.c
--- a/sys/netinet6/ip6_forward.c        Tue Jan 09 04:14:21 2018 +0000
+++ b/sys/netinet6/ip6_forward.c        Tue Jan 09 04:21:26 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ip6_forward.c,v 1.88 2017/08/02 01:28:03 ozaki-r Exp $ */
+/*     $NetBSD: ip6_forward.c,v 1.89 2018/01/09 04:21:26 ozaki-r Exp $ */
 /*     $KAME: ip6_forward.c,v 1.109 2002/09/11 08:10:17 sakane Exp $   */
 
 /*
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ip6_forward.c,v 1.88 2017/08/02 01:28:03 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ip6_forward.c,v 1.89 2018/01/09 04:21:26 ozaki-r Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_gateway.h"
@@ -416,7 +416,7 @@
                        rtcache_unref(rt, ro);
                        rt = NULL;
                        if (m->m_flags & M_CANFASTFWD)
-                               ip6flow_create(ro, m);
+                               ip6flow_create(ro, mcopy);
 #endif
                        if (mcopy)
                                goto freecopy;