Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Compilation of a kernel outside the build.sh framew...



details:   https://anonhg.NetBSD.org/src/rev/458a37350ff2
branches:  trunk
changeset: 828979:458a37350ff2
user:      reinoud <reinoud%NetBSD.org@localhost>
date:      Sat Jan 13 13:53:36 2018 +0000

description:
Compilation of a kernel outside the build.sh framework exposed the
uninitialised usage of `error' in interrupt_avert_intr(). In theory it can
reach the `out' label without `error' initialized. No idea if that really ever
happens in practice.

diffstat:

 sys/kern/subr_interrupt.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 72dbaf9d81a5 -r 458a37350ff2 sys/kern/subr_interrupt.c
--- a/sys/kern/subr_interrupt.c Sat Jan 13 13:49:10 2018 +0000
+++ b/sys/kern/subr_interrupt.c Sat Jan 13 13:53:36 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: subr_interrupt.c,v 1.2 2017/06/01 02:45:13 chs Exp $   */
+/*     $NetBSD: subr_interrupt.c,v 1.3 2018/01/13 13:53:36 reinoud Exp $       */
 
 /*
  * Copyright (c) 2015 Internet Initiative Japan Inc.
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: subr_interrupt.c,v 1.2 2017/06/01 02:45:13 chs Exp $");
+__KERNEL_RCSID(0, "$NetBSD: subr_interrupt.c,v 1.3 2018/01/13 13:53:36 reinoud Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -126,7 +126,7 @@
        kcpuset_t *cpuset;
        struct intrids_handler *ii_handler;
        intrid_t *ids;
-       int error, i, nids;
+       int error = 0, i, nids;
 
        kcpuset_create(&cpuset, true);
        kcpuset_set(cpuset, cpu_idx);



Home | Main Index | Thread Index | Old Index