[src/jdolecek-ncq]: src/sys/dev fix dump for siisata(4) to work - need to cal...

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/19878bd9007e
branches:  jdolecek-ncq
changeset: 822942:19878bd9007e
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Fri Jun 23 23:49:20 2017 +0000

description:
fix dump for siisata(4) to work - need to call drv_done() callback in order to
not leak xfers

while here, reduce the DELAY() for polled bio to make it go much faster,
same value as used in ahcisata(4)

needs also rev. 1.252 src/sys/arch/x86/x86/pmap.c to not trigger the
assertion, the pmap.c fix committed only on HEAD

diffstat:

 sys/dev/ata/TODO.ncq |  8 ++------
 sys/dev/ic/siisata.c |  4 ++--
 2 files changed, 4 insertions(+), 8 deletions(-)

diffs (43 lines):

diff -r 4db18e0cc958 -r 19878bd9007e sys/dev/ata/TODO.ncq
--- a/sys/dev/ata/TODO.ncq      Fri Jun 23 23:45:56 2017 +0000
+++ b/sys/dev/ata/TODO.ncq      Fri Jun 23 23:49:20 2017 +0000
@@ -6,12 +6,6 @@
 
 siisata - fix all new XXX and unmergable bits
 
-test crashdump with siisata
-- fails with recursive panic via pmap_kremove_local() regardless if
-  drive connected via PMP or direct (failed KASSERT(panicstr != NULL))
-- HEAD crashes same as branch
-- see kern/49610 for potential fix
-
 test wd* at umass?, confirm the ata_channel kludge works
 + add detach code (channel detach, free queue)
 
@@ -31,6 +25,8 @@
 
 Other random notes (do outside the NCQ branch):
 -----------------------------------------------------
+queue is allocated regardless if there are any drives, fix? 
+
 change wd(4) to use dksubr
 
 dump to unopened disk fails (e.g. dump do wd1b when wd1a not mounted), due
diff -r 4db18e0cc958 -r 19878bd9007e sys/dev/ic/siisata.c
--- a/sys/dev/ic/siisata.c      Fri Jun 23 23:45:56 2017 +0000
+++ b/sys/dev/ic/siisata.c      Fri Jun 23 23:49:20 2017 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: siisata.c,v 1.30.4.20 2017/06/23 23:45:56 jdolecek Exp $ */
+/* $NetBSD: siisata.c,v 1.30.4.21 2017/06/23 23:49:20 jdolecek Exp $ */
 
 /* from ahcisata_core.c */
 
@@ -79,7 +79,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: siisata.c,v 1.30.4.20 2017/06/23 23:45:56 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: siisata.c,v 1.30.4.21 2017/06/23 23:49:20 jdolecek Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>