Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-7]: src/sys/dev/usb Pull up following revision(s) (requested by s...



details:   https://anonhg.NetBSD.org/src/rev/a8a71f4bc399
branches:  netbsd-7
changeset: 799851:a8a71f4bc399
user:      snj <snj%NetBSD.org@localhost>
date:      Tue Mar 08 09:49:00 2016 +0000

description:
Pull up following revision(s) (requested by skrll in ticket #1134):
        sys/dev/usb/uhub.c: revision 1.130
Use the port status straight after the reset and not after the
        usbd_clear_port_feature(dev, port, UHF_C_PORT_RESET)
The Gadget USB HUB in the IBM x3250 sborrill sent me returns the wrong
status and this would appear to leave the attached cdce(4) in the default
state.  The next device probed fails as a result.

diffstat:

 sys/dev/usb/uhub.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (34 lines):

diff -r 71a01e1152fc -r a8a71f4bc399 sys/dev/usb/uhub.c
--- a/sys/dev/usb/uhub.c        Mon Mar 07 14:39:55 2016 +0000
+++ b/sys/dev/usb/uhub.c        Tue Mar 08 09:49:00 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uhub.c,v 1.124 2013/09/15 15:33:47 martin Exp $        */
+/*     $NetBSD: uhub.c,v 1.124.4.1 2016/03/08 09:49:00 snj Exp $       */
 /*     $FreeBSD: src/sys/dev/usb/uhub.c,v 1.18 1999/11/17 22:33:43 n_hibma Exp $       */
 
 /*
@@ -36,7 +36,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uhub.c,v 1.124 2013/09/15 15:33:47 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uhub.c,v 1.124.4.1 2016/03/08 09:49:00 snj Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -513,6 +513,7 @@
                            "port %d reset failed\n", port);
                        continue;
                }
+#if 0
                /* Get port status again, it might have changed during reset */
                err = usbd_get_port_status(dev, port, &up->status);
                if (err) {
@@ -520,6 +521,7 @@
                                 "error=%s\n", usbd_errstr(err)));
                        continue;
                }
+#endif
                status = UGETW(up->status.wPortStatus);
                change = UGETW(up->status.wPortChange);
                if (!(status & UPS_CURRENT_CONNECT_STATUS)) {



Home | Main Index | Thread Index | Old Index