[src/trunk]: src/sys/netinet Protect IFADDR_READER_FOREACH and obtained ifa w...

[ozaki-r <ozaki-r%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/8370b307b3b5
branches:  trunk
changeset: 828008:8370b307b3b5
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Wed Nov 22 07:40:45 2017 +0000

description:
Protect IFADDR_READER_FOREACH and obtained ifa with psz/psref

diffstat:

 sys/netinet/ip_carp.c |  62 ++++++++++++++++++++++++++++++++++++++++----------
 1 files changed, 49 insertions(+), 13 deletions(-)

diffs (197 lines):

diff -r 53f589cadc5e -r 8370b307b3b5 sys/netinet/ip_carp.c
--- a/sys/netinet/ip_carp.c     Wed Nov 22 05:43:28 2017 +0000
+++ b/sys/netinet/ip_carp.c     Wed Nov 22 07:40:45 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ip_carp.c,v 1.92 2017/11/16 03:07:18 ozaki-r Exp $     */
+/*     $NetBSD: ip_carp.c,v 1.93 2017/11/22 07:40:45 ozaki-r Exp $     */
 /*     $OpenBSD: ip_carp.c,v 1.113 2005/11/04 08:11:54 mcbride Exp $   */
 
 /*
@@ -33,7 +33,7 @@
 #endif
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ip_carp.c,v 1.92 2017/11/16 03:07:18 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ip_carp.c,v 1.93 2017/11/22 07:40:45 ozaki-r Exp $");
 
 /*
  * TODO:
@@ -59,8 +59,9 @@
 #include <sys/syslog.h>
 #include <sys/acct.h>
 #include <sys/cprng.h>
-
 #include <sys/cpu.h>
+#include <sys/pserialize.h>
+#include <sys/psref.h>
 
 #include <net/if.h>
 #include <net/pfil.h>
@@ -297,9 +298,11 @@
 #ifdef INET
        cur.s_addr = 0;
        do {
+               int s;
                found = 0;
                last = cur;
                cur.s_addr = 0xffffffff;
+               s = pserialize_read_enter();
                IFADDR_READER_FOREACH(ifa, &sc->sc_if) {
                        in.s_addr = ifatoia(ifa)->ia_addr.sin_addr.s_addr;
                        if (ifa->ifa_addr->sa_family == AF_INET &&
@@ -309,6 +312,7 @@
                                found++;
                        }
                }
+               pserialize_read_exit(s);
                if (found)
                        SHA1Update(&sc->sc_sha1, (void *)&cur, sizeof(cur));
        } while (found);
@@ -317,9 +321,11 @@
 #ifdef INET6
        memset(&cur6, 0x00, sizeof(cur6));
        do {
+               int s;
                found = 0;
                last6 = cur6;
                memset(&cur6, 0xff, sizeof(cur6));
+               s = pserialize_read_enter();
                IFADDR_READER_FOREACH(ifa, &sc->sc_if) {
                        in6 = ifatoia6(ifa)->ia_addr.sin6_addr;
                        if (IN6_IS_ADDR_LINKLOCAL(&in6))
@@ -331,6 +337,7 @@
                                found++;
                        }
                }
+               pserialize_read_exit(s);
                if (found)
                        SHA1Update(&sc->sc_sha1, (void *)&cur6, sizeof(cur6));
        } while (found);
@@ -375,11 +382,16 @@
 carp_setroute(struct carp_softc *sc, int cmd)
 {
        struct ifaddr *ifa;
-       int s;
+       int s, bound;
 
        KERNEL_LOCK(1, NULL);
-       s = splsoftnet();
+       bound = curlwp_bind();
+       s = pserialize_read_enter();
        IFADDR_READER_FOREACH(ifa, &sc->sc_if) {
+               struct psref psref;
+               ifa_acquire(ifa, &psref);
+               pserialize_read_exit(s);
+
                switch (ifa->ifa_addr->sa_family) {
                case AF_INET: {
                        int count = 0;
@@ -473,8 +485,11 @@
                default:
                        break;
                }
+               s = pserialize_read_enter();
+               ifa_release(ifa, &psref);
        }
-       splx(s);
+       pserialize_read_exit(s);
+       curlwp_bindx(bound);
        KERNEL_UNLOCK_ONE(NULL);
 }
 
@@ -1240,18 +1255,27 @@
 carp_send_arp(struct carp_softc *sc)
 {
        struct ifaddr *ifa;
-       int s;
+       int s, bound;
 
        KERNEL_LOCK(1, NULL);
-       s = splsoftnet();
+       bound = curlwp_bind();
+       s = pserialize_read_enter();
        IFADDR_READER_FOREACH(ifa, &sc->sc_if) {
+               struct psref psref;
 
                if (ifa->ifa_addr->sa_family != AF_INET)
                        continue;
 
+               ifa_acquire(ifa, &psref);
+               pserialize_read_exit(s);
+
                arpannounce(sc->sc_carpdev, ifa, CLLADDR(sc->sc_if.if_sadl));
+
+               s = pserialize_read_enter();
+               ifa_release(ifa, &psref);
        }
-       splx(s);
+       pserialize_read_exit(s);
+       curlwp_bindx(bound);
        KERNEL_UNLOCK_ONE(NULL);
 }
 
@@ -1262,21 +1286,29 @@
        struct ifaddr *ifa;
        struct in6_addr *in6;
        static struct in6_addr mcast = IN6ADDR_LINKLOCAL_ALLNODES_INIT;
-       int s;
+       int s, bound;
 
        KERNEL_LOCK(1, NULL);
-       s = splsoftnet();
-
+       bound = curlwp_bind();
+       s = pserialize_read_enter();
        IFADDR_READER_FOREACH(ifa, &sc->sc_if) {
+               struct psref psref;
 
                if (ifa->ifa_addr->sa_family != AF_INET6)
                        continue;
 
+               ifa_acquire(ifa, &psref);
+               pserialize_read_exit(s);
+
                in6 = &ifatoia6(ifa)->ia_addr.sin6_addr;
                nd6_na_output(sc->sc_carpdev, &mcast, in6,
                    ND_NA_FLAG_OVERRIDE, 1, NULL);
+
+               s = pserialize_read_enter();
+               ifa_release(ifa, &psref);
        }
-       splx(s);
+       pserialize_read_exit(s);
+       curlwp_bindx(bound);
        KERNEL_UNLOCK_ONE(NULL);
 }
 #endif /* INET6 */
@@ -1329,12 +1361,14 @@
                    (vh->sc_if.if_flags & (IFF_UP|IFF_RUNNING)) ==
                    (IFF_UP|IFF_RUNNING)) ||
                    (type == CARP_COUNT_MASTER && vh->sc_state == MASTER)) {
+                       int s = pserialize_read_enter();
                        IFADDR_READER_FOREACH(ifa, &vh->sc_if) {
                                if (ifa->ifa_addr->sa_family == AF_INET &&
                                    ia->ia_addr.sin_addr.s_addr ==
                                    ifatoia(ifa)->ia_addr.sin_addr.s_addr)
                                        count++;
                        }
+                       pserialize_read_exit(s);
                }
        }
        return (count);
@@ -1385,6 +1419,7 @@
        struct ifaddr *ifa;
 
        TAILQ_FOREACH(vh, &cif->vhif_vrs, sc_list) {
+               int s = pserialize_read_enter();
                IFADDR_READER_FOREACH(ifa, &vh->sc_if) {
                        if (IN6_ARE_ADDR_EQUAL(taddr,
                            &ifatoia6(ifa)->ia_addr.sin6_addr) &&
@@ -1392,6 +1427,7 @@
                            (IFF_UP|IFF_RUNNING)) && vh->sc_state == MASTER)
                                return (ifa);
                }
+               pserialize_read_exit(s);
        }
 
        return (NULL);