Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci/ixgbe Remove extra IXGBE_TX_LOCK()/IXGBE_TX_UNLO...



details:   https://anonhg.NetBSD.org/src/rev/a7c310d317ff
branches:  trunk
changeset: 806113:a7c310d317ff
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Wed Feb 04 04:37:13 2015 +0000

description:
Remove extra IXGBE_TX_LOCK()/IXGBE_TX_UNLOCK() from
ixgbe_free_transmit_structures(). This function is called in the end of
the detach function. if_stop was called and almost all resources were
freed, so it's not required to block the TX stuff.

diffstat:

 sys/dev/pci/ixgbe/ixgbe.c |  4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diffs (23 lines):

diff -r c7e90c747bf0 -r a7c310d317ff sys/dev/pci/ixgbe/ixgbe.c
--- a/sys/dev/pci/ixgbe/ixgbe.c Wed Feb 04 03:17:29 2015 +0000
+++ b/sys/dev/pci/ixgbe/ixgbe.c Wed Feb 04 04:37:13 2015 +0000
@@ -59,7 +59,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*$FreeBSD: src/sys/dev/ixgbe/ixgbe.c,v 1.51 2011/04/25 23:34:21 jfv Exp $*/
-/*$NetBSD: ixgbe.c,v 1.16 2015/02/04 03:17:29 msaitoh Exp $*/
+/*$NetBSD: ixgbe.c,v 1.17 2015/02/04 04:37:13 msaitoh Exp $*/
 
 #include "opt_inet.h"
 
@@ -3180,10 +3180,8 @@
        struct tx_ring *txr = adapter->tx_rings;
 
        for (int i = 0; i < adapter->num_queues; i++, txr++) {
-               IXGBE_TX_LOCK(txr);
                ixgbe_free_transmit_buffers(txr);
                ixgbe_dma_free(adapter, &txr->txdma);
-               IXGBE_TX_UNLOCK(txr);
                IXGBE_TX_LOCK_DESTROY(txr);
        }
        free(adapter->tx_rings, M_DEVBUF);



Home | Main Index | Thread Index | Old Index