Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/miscfs/genfs Allow layer_node_create() with unlocked low...



details:   https://anonhg.NetBSD.org/src/rev/89541411b1d2
branches:  trunk
changeset: 793176:89541411b1d2
user:      hannken <hannken%NetBSD.org@localhost>
date:      Wed Jan 29 08:27:04 2014 +0000

description:
Allow layer_node_create() with unlocked lower node and change
layer_bypass() to enter nodes from creation operations unlocked.

diffstat:

 sys/miscfs/genfs/layer_subr.c  |  6 ++----
 sys/miscfs/genfs/layer_vnops.c |  7 ++-----
 2 files changed, 4 insertions(+), 9 deletions(-)

diffs (56 lines):

diff -r a1a452f3cf88 -r 89541411b1d2 sys/miscfs/genfs/layer_subr.c
--- a/sys/miscfs/genfs/layer_subr.c     Wed Jan 29 06:59:53 2014 +0000
+++ b/sys/miscfs/genfs/layer_subr.c     Wed Jan 29 08:27:04 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: layer_subr.c,v 1.32 2011/06/12 03:35:58 rmind Exp $    */
+/*     $NetBSD: layer_subr.c,v 1.33 2014/01/29 08:27:04 hannken Exp $  */
 
 /*
  * Copyright (c) 1999 National Aeronautics & Space Administration
@@ -69,7 +69,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: layer_subr.c,v 1.32 2011/06/12 03:35:58 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: layer_subr.c,v 1.33 2014/01/29 08:27:04 hannken Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -260,8 +260,6 @@
        struct vnode *aliasvp;
        struct layer_mount *lmp = MOUNTTOLAYERMOUNT(mp);
 
-       KASSERT(VOP_ISLOCKED(lowervp));
-
        mutex_enter(&lmp->layerm_hashlock);
        aliasvp = layer_node_find(mp, lowervp);
        if (aliasvp != NULL) {
diff -r a1a452f3cf88 -r 89541411b1d2 sys/miscfs/genfs/layer_vnops.c
--- a/sys/miscfs/genfs/layer_vnops.c    Wed Jan 29 06:59:53 2014 +0000
+++ b/sys/miscfs/genfs/layer_vnops.c    Wed Jan 29 08:27:04 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: layer_vnops.c,v 1.52 2014/01/23 10:13:57 hannken Exp $ */
+/*     $NetBSD: layer_vnops.c,v 1.53 2014/01/29 08:27:04 hannken Exp $ */
 
 /*
  * Copyright (c) 1999 National Aeronautics & Space Administration
@@ -170,7 +170,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: layer_vnops.c,v 1.52 2014/01/23 10:13:57 hannken Exp $");
+__KERNEL_RCSID(0, "$NetBSD: layer_vnops.c,v 1.53 2014/01/29 08:27:04 hannken Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -321,10 +321,7 @@
                 * as a lookup on "." would generate a locking error.
                 * So all the calls which get us here have a unlocked vpp. :-)
                 */
-               /* XXX: lock node until lookup returns unlocked nodes. */
-               vn_lock(**vppp, LK_EXCLUSIVE | LK_RETRY);
                error = layer_node_create(mp, **vppp, *vppp);
-               VOP_UNLOCK(**vppp);
                if (error) {
                        vrele(**vppp);
                        **vppp = NULL;



Home | Main Index | Thread Index | Old Index