Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/scsipi Use size for the size argument of memcmp, not...



details:   https://anonhg.NetBSD.org/src/rev/7c36dcdd87c7
branches:  trunk
changeset: 803988:7c36dcdd87c7
user:      joerg <joerg%NetBSD.org@localhost>
date:      Tue Nov 18 17:03:41 2014 +0000

description:
Use size for the size argument of memcmp, not the result of a compare.

diffstat:

 sys/dev/scsipi/scsipi_base.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 04d511138e3a -r 7c36dcdd87c7 sys/dev/scsipi/scsipi_base.c
--- a/sys/dev/scsipi/scsipi_base.c      Tue Nov 18 16:57:52 2014 +0000
+++ b/sys/dev/scsipi/scsipi_base.c      Tue Nov 18 17:03:41 2014 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: scsipi_base.c,v 1.163 2014/11/17 18:43:48 christos Exp $       */
+/*     $NetBSD: scsipi_base.c,v 1.164 2014/11/18 17:03:41 joerg Exp $  */
 
 /*-
  * Copyright (c) 1998, 1999, 2000, 2002, 2003, 2004 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: scsipi_base.c,v 1.163 2014/11/17 18:43:48 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: scsipi_base.c,v 1.164 2014/11/18 17:03:41 joerg Exp $");
 
 #include "opt_scsi.h"
 
@@ -1059,7 +1059,7 @@
                const struct scsipi_inquiry3_pattern *q =
                    &scsipi_inquiry3_quirk[i];
 #define MATCH(field) \
-    (q->field[0] ? memcmp(ib->field, q->field, sizeof(ib->field) == 0) : 1)
+    (q->field[0] ? memcmp(ib->field, q->field, sizeof(ib->field)) == 0 : 1)
                if (MATCH(vendor) && MATCH(product) && MATCH(revision))
                        return 0;
        }



Home | Main Index | Thread Index | Old Index