Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/bin/sh Fix a bug noticed by Soren Jacobsen running the netbs...



details:   https://anonhg.NetBSD.org/src/rev/26f1fb99a5a5
branches:  trunk
changeset: 826380:26f1fb99a5a5
user:      kre <kre%NetBSD.org@localhost>
date:      Thu Aug 31 05:09:38 2017 +0000

description:
Fix a bug noticed by Soren Jacobsen running the netbsd-6-0 build.sh which
causes a core dump in some exotic circumstances (when restoring local
variables when a function returns).  ("build.sh makewrapper" exposed it.)

This was introduced in 1.63 - not as part of the substance of that
change (addition) but as an unrelated "must be the right thing to do"
cleanup, which wasn't...

diffstat:

 bin/sh/var.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r d4c7749c0f26 -r 26f1fb99a5a5 bin/sh/var.c
--- a/bin/sh/var.c      Thu Aug 31 02:48:55 2017 +0000
+++ b/bin/sh/var.c      Thu Aug 31 05:09:38 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: var.c,v 1.66 2017/07/24 13:36:15 kre Exp $     */
+/*     $NetBSD: var.c,v 1.67 2017/08/31 05:09:38 kre Exp $     */
 
 /*-
  * Copyright (c) 1991, 1993
@@ -37,7 +37,7 @@
 #if 0
 static char sccsid[] = "@(#)var.c      8.3 (Berkeley) 5/4/95";
 #else
-__RCSID("$NetBSD: var.c,v 1.66 2017/07/24 13:36:15 kre Exp $");
+__RCSID("$NetBSD: var.c,v 1.67 2017/08/31 05:09:38 kre Exp $");
 #endif
 #endif /* not lint */
 
@@ -476,7 +476,7 @@
                return;
        }
        vp = ckmalloc(sizeof (*vp));
-       vp->flags = flags & ~(VNOFUNC|VFUNCREF|VSTRFIXED);
+       vp->flags = flags & ~(VNOFUNC|VFUNCREF);
        vp->text = s;
        vp->name_len = nlen;
        vp->next = *vpp;



Home | Main Index | Thread Index | Old Index