Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci Remove an extra mii_pollstat() call. The PHY sta...



details:   https://anonhg.NetBSD.org/src/rev/e23e70d1b4fd
branches:  trunk
changeset: 787336:e23e70d1b4fd
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Tue Jun 11 16:37:10 2013 +0000

description:
Remove an extra mii_pollstat() call. The PHY status should be updated
by adjacent mii_tick() call. I suspect that this mii_pollstat() call was
added to do workaround for broken MII_TICK code. A lot of MII PHY drivers
had bugs in MII_TICK and those bugs were fixed.

diffstat:

 sys/dev/pci/if_sk.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 801363d2fdaa -r e23e70d1b4fd sys/dev/pci/if_sk.c
--- a/sys/dev/pci/if_sk.c       Tue Jun 11 16:18:48 2013 +0000
+++ b/sys/dev/pci/if_sk.c       Tue Jun 11 16:37:10 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_sk.c,v 1.73 2013/03/30 03:21:07 christos Exp $      */
+/*     $NetBSD: if_sk.c,v 1.74 2013/06/11 16:37:10 msaitoh Exp $       */
 
 /*-
  * Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -115,7 +115,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_sk.c,v 1.73 2013/03/30 03:21:07 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_sk.c,v 1.74 2013/06/11 16:37:10 msaitoh Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -2219,7 +2219,6 @@
        SK_XM_CLRBIT_2(sc_if, XM_IMR, XM_IMR_GP0_SET);
        SK_XM_READ_2(sc_if, XM_ISR);
        mii_tick(mii);
-       mii_pollstat(mii);
        callout_stop(&sc_if->sk_tick_ch);
 }
 



Home | Main Index | Thread Index | Old Index