Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev Provisionally return to declaring midi_cd unconditio...



details:   https://anonhg.NetBSD.org/src/rev/76165daacaa3
branches:  trunk
changeset: 827475:76165daacaa3
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Oct 29 17:57:21 2017 +0000

description:
Provisionally return to declaring midi_cd unconditionally.

Apparently this breaks compiling some kernels, although how they ever
managed to link if midi_cd is not declared in ioconf.h, and therefore
presumably not defined in ioconf.c, is beyond me.

Maybe someone who knows how sequencer is supposed to work, and/or
someone who knows how arm kernels are linked, can figure this out...

diffstat:

 sys/dev/sequencer.c |  10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diffs (33 lines):

diff -r 2a3d2ff3ac54 -r 76165daacaa3 sys/dev/sequencer.c
--- a/sys/dev/sequencer.c       Sun Oct 29 17:19:14 2017 +0000
+++ b/sys/dev/sequencer.c       Sun Oct 29 17:57:21 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: sequencer.c,v 1.69 2017/10/28 04:16:04 riastradh Exp $ */
+/*     $NetBSD: sequencer.c,v 1.70 2017/10/29 17:57:21 riastradh Exp $ */
 
 /*
  * Copyright (c) 1998, 2008 The NetBSD Foundation, Inc.
@@ -55,7 +55,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sequencer.c,v 1.69 2017/10/28 04:16:04 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sequencer.c,v 1.70 2017/10/29 17:57:21 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "sequencer.h"
@@ -99,9 +99,13 @@
  *
  * XXX XXX XXX Apparently sequencer.ioconf doesn't actually make the
  * sequencer cdev!  Did this ever work?
+ *
+ * XXX XXX XXX Apparently there are even some kernels that include a
+ * sequencer pseudo-device but exclude any midi device.  How do they
+ * even link??
  */
+extern struct cfdriver midi_cd;
 #ifdef _MODULE
-extern struct cfdriver midi_cd;
 extern struct cfdriver sequencer_cd;
 #endif
 



Home | Main Index | Thread Index | Old Index