Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Add comment questioning lock asymmetry.



details:   https://anonhg.NetBSD.org/src/rev/2f36d0d92e5d
branches:  trunk
changeset: 785455:2f36d0d92e5d
user:      gdt <gdt%NetBSD.org@localhost>
date:      Thu Mar 14 19:13:17 2013 +0000

description:
Add comment questioning lock asymmetry.

diffstat:

 sys/kern/uipc_socket.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r 52db085c4093 -r 2f36d0d92e5d sys/kern/uipc_socket.c
--- a/sys/kern/uipc_socket.c    Thu Mar 14 18:49:20 2013 +0000
+++ b/sys/kern/uipc_socket.c    Thu Mar 14 19:13:17 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uipc_socket.c,v 1.213 2013/02/14 21:57:58 christos Exp $       */
+/*     $NetBSD: uipc_socket.c,v 1.214 2013/03/14 19:13:17 gdt Exp $    */
 
 /*-
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.213 2013/02/14 21:57:58 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.214 2013/03/14 19:13:17 gdt Exp $");
 
 #include "opt_compat_netbsd.h"
 #include "opt_sock_counters.h"
@@ -538,6 +538,7 @@
                lock = lockso->so_lock;
                so->so_lock = lock;
                mutex_obj_hold(lock);
+               /* XXX Why is this not solock, to match sounlock? */
                mutex_enter(lock);
        } else {
                /* Lock assigned and taken during PRU_ATTACH. */



Home | Main Index | Thread Index | Old Index