Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/pgoyette-localcount]: src/sys/dev Add a comment to describe why we didn'...



details:   https://anonhg.NetBSD.org/src/rev/58e19473cc4c
branches:  pgoyette-localcount
changeset: 852860:58e19473cc4c
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Mon Jul 25 03:40:52 2016 +0000

description:
Add a comment to describe why we didn't convert one caller of
device_lokup_private().

diffstat:

 sys/dev/cgd.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (30 lines):

diff -r f82e81950ad2 -r 58e19473cc4c sys/dev/cgd.c
--- a/sys/dev/cgd.c     Mon Jul 25 03:30:51 2016 +0000
+++ b/sys/dev/cgd.c     Mon Jul 25 03:40:52 2016 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: cgd.c,v 1.108.2.13 2016/07/24 10:44:57 pgoyette Exp $ */
+/* $NetBSD: cgd.c,v 1.108.2.14 2016/07/25 03:40:52 pgoyette Exp $ */
 
 /*-
  * Copyright (c) 2002 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.108.2.13 2016/07/24 10:44:57 pgoyette Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.108.2.14 2016/07/25 03:40:52 pgoyette Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>
@@ -910,6 +910,11 @@
                return EINVAL;  /* XXX: should this be ENXIO? */
        }
 
+       /*
+        * XXX This appears to be redundant, given the initialization
+        * XXX when it was declared.  Leave it for now, but don't
+        * XXX take an extra reference to the device!
+        */
        cs = device_lookup_private(&cgd_cd, unit);
        if (cs == NULL || !DK_ATTACHED(dksc)) {
                cgu->cgu_dev = 0;



Home | Main Index | Thread Index | Old Index