Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Explain where this will fail.



details:   https://anonhg.NetBSD.org/src/rev/e4fa6f0a923e
branches:  trunk
changeset: 791571:e4fa6f0a923e
user:      christos <christos%NetBSD.org@localhost>
date:      Sat Nov 23 22:15:16 2013 +0000

description:
Explain where this will fail.

diffstat:

 sys/kern/kern_exec.c |  13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diffs (34 lines):

diff -r 40a1e55dc1b8 -r e4fa6f0a923e sys/kern/kern_exec.c
--- a/sys/kern/kern_exec.c      Sat Nov 23 22:01:12 2013 +0000
+++ b/sys/kern/kern_exec.c      Sat Nov 23 22:15:16 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_exec.c,v 1.366 2013/11/22 21:04:11 christos Exp $ */
+/*     $NetBSD: kern_exec.c,v 1.367 2013/11/23 22:15:16 christos Exp $ */
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -59,7 +59,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.366 2013/11/22 21:04:11 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.367 2013/11/23 22:15:16 christos Exp $");
 
 #include "opt_exec.h"
 #include "opt_execfmt.h"
@@ -1083,10 +1083,11 @@
 #ifdef notyet
        /*
         * Although this works most of the time [since the entry was just
-        * entered in the cache] we don't use it because it theoretically
-        * can fail and it is not the cleanest interface, because there
-        * could be races. When the namei cache is re-written, this can
-        * be changed to use the appropriate function.
+        * entered in the cache] we don't use it because it will fail for
+        * entries that are not placed in the cache because their name is
+        * longer than NCHNAMLEN and it is not the cleanest interface,
+        * because there could be races. When the namei cache is re-written,
+        * this can be changed to use the appropriate function.
         */
        else if (!(error = vnode_to_path(dp, MAXPATHLEN, p->p_textvp, l, p)))
                data->ed_pack.ep_path = dp;



Home | Main Index | Thread Index | Old Index