Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/ufs/lfs Remove stray KERNEL_UNLOCK_ONE() in error path o...



details:   https://anonhg.NetBSD.org/src/rev/753f505c9a69
branches:  trunk
changeset: 790418:753f505c9a69
user:      dholland <dholland%NetBSD.org@localhost>
date:      Mon Oct 07 05:19:23 2013 +0000

description:
Remove stray KERNEL_UNLOCK_ONE() in error path of lfs_markv().
>From Wolfgang Stukenbrock in PR 44370.

This error path is only reachable if lfs_markv is handed an out of
range inode number, so it's unlikely that it gets tickled very often.

It isn't clear to me that we need the kernel lock in here at all, as
the path to lfs_markv that's actually used at this point (via fcntl)
doesn't take it. But, one thing at a time.

diffstat:

 sys/ufs/lfs/lfs_syscalls.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 8f3f7d822d29 -r 753f505c9a69 sys/ufs/lfs/lfs_syscalls.c
--- a/sys/ufs/lfs/lfs_syscalls.c        Mon Oct 07 05:06:45 2013 +0000
+++ b/sys/ufs/lfs/lfs_syscalls.c        Mon Oct 07 05:19:23 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: lfs_syscalls.c,v 1.148 2013/07/28 01:05:52 dholland Exp $      */
+/*     $NetBSD: lfs_syscalls.c,v 1.149 2013/10/07 05:19:23 dholland Exp $      */
 
 /*-
  * Copyright (c) 1999, 2000, 2001, 2002, 2003, 2007, 2007, 2008
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_syscalls.c,v 1.148 2013/07/28 01:05:52 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_syscalls.c,v 1.149 2013/10/07 05:19:23 dholland Exp $");
 
 #ifndef LFS
 # define LFS           /* for prototypes in syscallargs.h */
@@ -524,7 +524,6 @@
         */
 
 err3:
-       KERNEL_UNLOCK_ONE(NULL);
        /*
         * XXX should do segwrite here anyway?
         */



Home | Main Index | Thread Index | Old Index