Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/i386/i386 PR kern/55114: Install fails with "cpu_sw...



details:   https://anonhg.NetBSD.org/src/rev/59b21d18fd78
branches:  trunk
changeset: 850192:59b21d18fd78
user:      ad <ad%NetBSD.org@localhost>
date:      Fri Mar 27 21:05:03 2020 +0000

description:
PR kern/55114: Install fails with "cpu_switchto: switching above IPL_SCHED (8)"

cpu_switch(): Remove stuff dealing with interrupt levels.  From memory it
was something to do with TLB shootdown interrupts but they have long been
outside the SPL framework.

diffstat:

 sys/arch/i386/i386/locore.S |  19 ++-----------------
 1 files changed, 2 insertions(+), 17 deletions(-)

diffs (47 lines):

diff -r 3e432ac46c1a -r 59b21d18fd78 sys/arch/i386/i386/locore.S
--- a/sys/arch/i386/i386/locore.S       Fri Mar 27 21:03:17 2020 +0000
+++ b/sys/arch/i386/i386/locore.S       Fri Mar 27 21:05:03 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: locore.S,v 1.178 2020/02/10 22:13:50 skrll Exp $       */
+/*     $NetBSD: locore.S,v 1.179 2020/03/27 21:05:03 ad Exp $  */
 
 /*
  * Copyright-o-rama!
@@ -128,7 +128,7 @@
  */
 
 #include <machine/asm.h>
-__KERNEL_RCSID(0, "$NetBSD: locore.S,v 1.178 2020/02/10 22:13:50 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: locore.S,v 1.179 2020/03/27 21:05:03 ad Exp $");
 
 #include "opt_copy_symtab.h"
 #include "opt_ddb.h"
@@ -1301,17 +1301,6 @@
        pushl   %esi
        pushl   %edi
 
-#if defined(DIAGNOSTIC) && !defined(XENPV)
-       cmpl    $IPL_SCHED,CPUVAR(ILEVEL)
-       jbe     0f
-       pushl   CPUVAR(ILEVEL)
-       pushl   $.Lstr
-       call    _C_LABEL(panic)
-       addl    $8,%esp
-.Lstr: .string "cpu_switchto: switching above IPL_SCHED (%d)\0"
-0:
-#endif
-
        movl    16(%esp),%esi           /* oldlwp */
        movl    20(%esp),%edi           /* newlwp */
        movl    24(%esp),%edx           /* returning */
@@ -1408,10 +1397,6 @@
        pushl   %edi
        call    _C_LABEL(i386_tls_switch)
        addl    $4,%esp
-#else
-       /* Raise the IPL to IPL_HIGH. Dropping the priority is deferred until
-        * mi_switch(), when cpu_switchto() returns. XXX Still needed? */
-       movl    $IPL_HIGH,CPUVAR(ILEVEL)
 #endif
 
 switch_return:



Home | Main Index | Thread Index | Old Index