Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/external/bsd/drm2/dist/drm/nouveau Don't abuse kref abst...



details:   https://anonhg.NetBSD.org/src/rev/e2e26dc66d3a
branches:  trunk
changeset: 835110:e2e26dc66d3a
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Mon Aug 27 07:37:07 2018 +0000

description:
Don't abuse kref abstraction.

diffstat:

 sys/external/bsd/drm2/dist/drm/nouveau/nouveau_fence.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r f5210d7b977c -r e2e26dc66d3a sys/external/bsd/drm2/dist/drm/nouveau/nouveau_fence.c
--- a/sys/external/bsd/drm2/dist/drm/nouveau/nouveau_fence.c    Mon Aug 27 07:36:58 2018 +0000
+++ b/sys/external/bsd/drm2/dist/drm/nouveau/nouveau_fence.c    Mon Aug 27 07:37:07 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nouveau_fence.c,v 1.11 2018/08/27 07:36:58 riastradh Exp $     */
+/*     $NetBSD: nouveau_fence.c,v 1.12 2018/08/27 07:37:07 riastradh Exp $     */
 
 /*
  * Copyright (C) 2007 Ben Skeggs.
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nouveau_fence.c,v 1.11 2018/08/27 07:36:58 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nouveau_fence.c,v 1.12 2018/08/27 07:37:07 riastradh Exp $");
 
 #include <drm/drmP.h>
 
@@ -557,7 +557,8 @@
         * caller should have a reference on the fence,
         * else fence could get freed here
         */
-       WARN_ON(atomic_read(&fence->base.refcount.refcount) <= 1);
+       WARN_ON(!kref_referenced_p(&fence->base.refcount));
+       WARN_ON(kref_exclusive_p(&fence->base.refcount));
 
        /*
         * This needs uevents to work correctly, but fence_add_callback relies on



Home | Main Index | Thread Index | Old Index