Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/distrib/utils/sysinst Fix another botch of my dumb patch in ...
details: https://anonhg.NetBSD.org/src/rev/567008ecde2b
branches: trunk
changeset: 790468:567008ecde2b
user: tsutsui <tsutsui%NetBSD.org@localhost>
date: Sun Oct 13 15:32:14 2013 +0000
description:
Fix another botch of my dumb patch in PR/45990; add missing braces.
The offset of MBR partition 0 was unintentionally set to 2048 even on
small (<=128GB) disks. Probably we should rethink the threshold,
but anyway sysinst(8) should follow fdisk(8) default.
http://nxr.NetBSD.org/xref/src/sbin/fdisk/fdisk.c?r=1.145#1199
http://cvsweb.NetBSD.org/bsdweb.cgi/src/sbin/fdisk/fdisk.c#rev1.129
The problem is pointed out and analyzed by Simon Nicolussi in PR/48304.
Should be pulled up to all netbsd-6* branches.
diffstat:
distrib/utils/sysinst/mbr.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diffs (20 lines):
diff -r 66f90099e135 -r 567008ecde2b distrib/utils/sysinst/mbr.c
--- a/distrib/utils/sysinst/mbr.c Sun Oct 13 12:29:42 2013 +0000
+++ b/distrib/utils/sysinst/mbr.c Sun Oct 13 15:32:14 2013 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: mbr.c,v 1.91 2012/05/26 05:09:59 tsutsui Exp $ */
+/* $NetBSD: mbr.c,v 1.92 2013/10/13 15:32:14 tsutsui Exp $ */
/*
* Copyright 1997 Piermont Information Systems Inc.
@@ -1890,8 +1890,9 @@
}
} else {
/* Use 1MB offset for large (>128GB) disks */
- if (dlsize > 2048 * 1024 * 128)
+ if (dlsize > 2048 * 1024 * 128) {
ptn_alignment = 2048;
ptn_0_offset = 2048;
+ }
}
}
Home |
Main Index |
Thread Index |
Old Index