Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic nvme(4): Don't set prp1 for DEL_IOCQ



details:   https://anonhg.NetBSD.org/src/rev/0ce01d53ef3d
branches:  trunk
changeset: 824242:0ce01d53ef3d
user:      nonaka <nonaka%NetBSD.org@localhost>
date:      Mon May 29 02:25:37 2017 +0000

description:
nvme(4): Don't set prp1 for DEL_IOCQ

> NVM_ADMIN_DEL_IOCQ does not need prp1 (just as NVM_ADMIN_DEL_IOSQ).
> Remove what is likely a cut'n'paste error from the *_ADD_* code.

from OpenBSD nvme.c r1.56.

diffstat:

 sys/dev/ic/nvme.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 0de1afaf7366 -r 0ce01d53ef3d sys/dev/ic/nvme.c
--- a/sys/dev/ic/nvme.c Mon May 29 02:24:00 2017 +0000
+++ b/sys/dev/ic/nvme.c Mon May 29 02:25:37 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nvme.c,v 1.28 2017/05/29 02:24:00 nonaka Exp $ */
+/*     $NetBSD: nvme.c,v 1.29 2017/05/29 02:25:37 nonaka Exp $ */
 /*     $OpenBSD: nvme.c,v 1.49 2016/04/18 05:59:50 dlg Exp $ */
 
 /*
@@ -18,7 +18,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.28 2017/05/29 02:24:00 nonaka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nvme.c,v 1.29 2017/05/29 02:25:37 nonaka Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1296,7 +1296,6 @@
 
        memset(&sqe, 0, sizeof(sqe));
        sqe.opcode = NVM_ADMIN_DEL_IOCQ;
-       htolem64(&sqe.prp1, NVME_DMA_DVA(q->q_sq_dmamem));
        htolem16(&sqe.qid, q->q_id);
 
        rv = nvme_poll(sc, sc->sc_admin_q, ccb, nvme_sqe_fill, NVME_TIMO_QOP);



Home | Main Index | Thread Index | Old Index