[src/trunk]: src/sys/netinet No need for membar_datadep_consumer here.

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/8222c76847ba
branches:  trunk
changeset: 823192:8222c76847ba
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sat Apr 15 17:06:45 2017 +0000

description:
No need for membar_datadep_consumer here.

PSLIST_READER_FOREACH takes care of it already.
PSLIST_WRITER_FOREACH is exclusive so doesn't need it.

diffstat:

 sys/netinet/ip_encap.c |  14 ++------------
 1 files changed, 2 insertions(+), 12 deletions(-)

diffs (63 lines):

diff -r 61d6912434ee -r 8222c76847ba sys/netinet/ip_encap.c
--- a/sys/netinet/ip_encap.c    Sat Apr 15 14:00:30 2017 +0000
+++ b/sys/netinet/ip_encap.c    Sat Apr 15 17:06:45 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ip_encap.c,v 1.63 2017/04/07 03:31:50 ozaki-r Exp $    */
+/*     $NetBSD: ip_encap.c,v 1.64 2017/04/15 17:06:45 riastradh Exp $  */
 /*     $KAME: ip_encap.c,v 1.73 2001/10/02 08:30:58 itojun Exp $       */
 
 /*
@@ -68,7 +68,7 @@
 #define USE_RADIX
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ip_encap.c,v 1.63 2017/04/07 03:31:50 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ip_encap.c,v 1.64 2017/04/15 17:06:45 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_mrouting.h"
@@ -274,8 +274,6 @@
        PSLIST_READER_FOREACH(ep, &encap_table, struct encaptab, chain) {
                struct psref elem_psref;
 
-               membar_datadep_consumer();
-
                if (ep->af != AF_INET)
                        continue;
                if (ep->proto >= 0 && ep->proto != proto)
@@ -442,8 +440,6 @@
        PSLIST_READER_FOREACH(ep, &encap_table, struct encaptab, chain) {
                struct psref elem_psref;
 
-               membar_datadep_consumer();
-
                if (ep->af != AF_INET6)
                        continue;
                if (ep->proto >= 0 && ep->proto != proto)
@@ -678,8 +674,6 @@
        /* check if anyone have already attached with exactly same config */
        pss = pserialize_read_enter();
        PSLIST_READER_FOREACH(ep, &encap_table, struct encaptab, chain) {
-               membar_datadep_consumer();
-
                if (ep->af != af)
                        continue;
                if (ep->proto != proto)
@@ -920,8 +914,6 @@
        PSLIST_READER_FOREACH(ep, &encap_table, struct encaptab, chain) {
                struct psref elem_psref;
 
-               membar_datadep_consumer();
-
                if (ep->af != AF_INET6)
                        continue;
                if (ep->proto >= 0 && ep->proto != nxt)
@@ -959,8 +951,6 @@
        KASSERT(encap_lock_held());
 
        PSLIST_WRITER_FOREACH(p, &encap_table, struct encaptab, chain) {
-               membar_datadep_consumer();
-
                if (p == ep) {
                        error = encap_remove(p);
                        if (error)