Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/hp300/stand/common Remove '__attribute__((__packed_...



details:   https://anonhg.NetBSD.org/src/rev/0bc5674520bc
branches:  trunk
changeset: 780467:0bc5674520bc
user:      tsutsui <tsutsui%NetBSD.org@localhost>
date:      Thu Jul 26 17:15:22 2012 +0000

description:
Remove '__attribute__((__packed__))' from structure definisions
for Am7990 LANCE registers where no implicit padding is expected.

gcc 4.5.3 seems to generate strange and wrong instructions
(four moveb insns against u_short members) if packed attribute
is specified in this case, then netboot fails immediately.

Should be pulled up to netbsd-6.

diffstat:

 sys/arch/hp300/stand/common/if_lereg.h |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 56e5409f2bed -r 0bc5674520bc sys/arch/hp300/stand/common/if_lereg.h
--- a/sys/arch/hp300/stand/common/if_lereg.h    Thu Jul 26 14:58:16 2012 +0000
+++ b/sys/arch/hp300/stand/common/if_lereg.h    Thu Jul 26 17:15:22 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_lereg.h,v 1.5 2005/12/11 12:17:19 christos Exp $    */
+/*     $NetBSD: if_lereg.h,v 1.6 2012/07/26 17:15:22 tsutsui Exp $     */
 
 /*
  * Copyright (c) 1982, 1990 The Regents of the University of California.
@@ -50,7 +50,7 @@
        vu_char ler0_id;        /* ID */
        u_char  ler0_pad1;
        vu_char ler0_status;    /* interrupt enable/status */
-} __attribute__((__packed__));
+};
 
 /*
  * Control and status bits -- lereg0
@@ -65,7 +65,7 @@
 struct lereg1 {
        vu_short        ler1_rdp;       /* data port */
        vu_short        ler1_rap;       /* register select port */
-} __attribute__((__packed__));
+};
 
 /*
  * Control and status bits -- lereg1



Home | Main Index | Thread Index | Old Index