Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch Use bus_dmamem_common.



details:   https://anonhg.NetBSD.org/src/rev/7dd600edcf27
branches:  trunk
changeset: 746835:7dd600edcf27
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Fri Aug 21 03:45:10 2009 +0000

description:
Use bus_dmamem_common.

diffstat:

 sys/arch/algor/algor/bus_dma.c              |  142 +++-----------------------
 sys/arch/algor/conf/files.algor             |    4 +-
 sys/arch/cobalt/cobalt/bus.c                |  148 +++------------------------
 sys/arch/cobalt/conf/files.cobalt           |    4 +-
 sys/arch/ews4800mips/conf/files.ews4800mips |    4 +-
 sys/arch/ews4800mips/ews4800mips/bus_dma.c  |  148 +++------------------------
 6 files changed, 62 insertions(+), 388 deletions(-)

diffs (truncated from 705 to 300 lines):

diff -r 12e705017f3c -r 7dd600edcf27 sys/arch/algor/algor/bus_dma.c
--- a/sys/arch/algor/algor/bus_dma.c    Fri Aug 21 03:39:41 2009 +0000
+++ b/sys/arch/algor/algor/bus_dma.c    Fri Aug 21 03:45:10 2009 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: bus_dma.c,v 1.20 2008/06/04 12:41:40 ad Exp $  */
+/*     $NetBSD: bus_dma.c,v 1.21 2009/08/21 03:45:10 thorpej Exp $     */
 
 /*-
  * Copyright (c) 1997, 1998, 2001 The NetBSD Foundation, Inc.
@@ -32,7 +32,7 @@
 
 #include <sys/cdefs.h>                 /* RCS ID & Copyright macro defns */
 
-__KERNEL_RCSID(0, "$NetBSD: bus_dma.c,v 1.20 2008/06/04 12:41:40 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: bus_dma.c,v 1.21 2009/08/21 03:45:10 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -51,6 +51,8 @@
 #include <machine/cpu.h>
 #include <machine/locore.h>
 
+#include <common/bus_dma/bus_dmamem_common.h>
+
 /*
  * Common function for DMA map creation.  May be called by bus-specific
  * DMA map creation functions.
@@ -554,54 +556,10 @@
     bus_size_t boundary, bus_dma_segment_t *segs, int nsegs, int *rsegs,
     int flags, paddr_t low, paddr_t high)
 {
-       paddr_t curaddr, lastaddr;
-       struct vm_page *m;    
-       struct pglist mlist;
-       int curseg, error;
 
-       /* Always round the size. */
-       size = round_page(size);
-
-       /*
-        * Allocate pages from the VM system.
-        */
-       error = uvm_pglistalloc(size, low, high, alignment, boundary,
-           &mlist, nsegs, (flags & BUS_DMA_NOWAIT) == 0);
-       if (error)
-               return (error);
-
-       /*
-        * Compute the location, size, and number of segments actually
-        * returned by the VM code.
-        */
-       m = mlist.tqh_first;
-       curseg = 0;
-       lastaddr = segs[curseg].ds_addr = VM_PAGE_TO_PHYS(m);
-       segs[curseg].ds_len = PAGE_SIZE;
-       m = m->pageq.queue.tqe_next;
-
-       for (; m != NULL; m = m->pageq.queue.tqe_next) {
-               curaddr = VM_PAGE_TO_PHYS(m);
-#ifdef DIAGNOSTIC
-               if (curaddr < low || curaddr >= high) {
-                       printf("uvm_pglistalloc returned non-sensical"
-                           " address 0x%lx\n", curaddr);
-                       panic("_bus_dmamem_alloc");
-               }
-#endif
-               if (curaddr == (lastaddr + PAGE_SIZE))
-                       segs[curseg].ds_len += PAGE_SIZE;
-               else {
-                       curseg++;
-                       segs[curseg].ds_addr = curaddr;
-                       segs[curseg].ds_len = PAGE_SIZE;
-               }
-               lastaddr = curaddr;
-       }
-
-       *rsegs = curseg + 1;
-
-       return (0);
+       return (_bus_dmamem_alloc_range_common(t, size, alignment, boundary,
+                                              segs, nsegs, rsegs, flags,
+                                              low, high));
 }
 
 /*
@@ -611,25 +569,8 @@
 void
 _bus_dmamem_free(bus_dma_tag_t t, bus_dma_segment_t *segs, int nsegs)
 {
-       struct vm_page *m;
-       bus_addr_t addr;
-       struct pglist mlist;
-       int curseg;
 
-       /*
-        * Build a list of pages to free back to the VM system.
-        */
-       TAILQ_INIT(&mlist);
-       for (curseg = 0; curseg < nsegs; curseg++) {
-               for (addr = segs[curseg].ds_addr;
-                   addr < (segs[curseg].ds_addr + segs[curseg].ds_len);
-                   addr += PAGE_SIZE) {
-                       m = PHYS_TO_VM_PAGE(addr);
-                       TAILQ_INSERT_TAIL(&mlist, m, pageq.queue);
-               }
-       }
-
-       uvm_pglistfree(&mlist);
+       _bus_dmamem_free_common(t, segs, nsegs);
 }
 
 /*
@@ -640,11 +581,6 @@
 _bus_dmamem_map(bus_dma_tag_t t, bus_dma_segment_t *segs, int nsegs,
     size_t size, void **kvap, int flags)
 {
-       vaddr_t va;
-       bus_addr_t addr;
-       int curseg;
-       const uvm_flag_t kmflags =
-           (flags & BUS_DMA_NOWAIT) != 0 ? UVM_KMF_NOWAIT : 0;
 
        /*
         * If we're only mapping 1 segment, use K0SEG, to avoid
@@ -658,29 +594,8 @@
                return (0);
        }
 
-       size = round_page(size);
-
-       va = uvm_km_alloc(kernel_map, size, 0, UVM_KMF_VAONLY | kmflags);
-
-       if (va == 0)
-               return (ENOMEM);
-
-       *kvap = (void *)va;
-
-       for (curseg = 0; curseg < nsegs; curseg++) {
-               for (addr = segs[curseg].ds_addr;
-                   addr < (segs[curseg].ds_addr + segs[curseg].ds_len);
-                   addr += PAGE_SIZE, va += PAGE_SIZE, size -= PAGE_SIZE) {
-                       if (size == 0)
-                               panic("_bus_dmamem_map: size botch");
-                       pmap_enter(pmap_kernel(), va, addr,
-                           VM_PROT_READ | VM_PROT_WRITE,
-                           PMAP_WIRED | VM_PROT_READ | VM_PROT_WRITE);
-               }
-       }
-       pmap_update(pmap_kernel());
-
-       return (0);
+       /* XXX BUS_DMA_COHERENT */
+       return (_bus_dmamem_map_common(t, segs, nsegs, size, kvap, flags, 0));
 }
 
 /*
@@ -691,11 +606,6 @@
 _bus_dmamem_unmap(bus_dma_tag_t t, void *kva, size_t size)
 {
 
-#ifdef DIAGNOSTIC
-       if ((u_long)kva & PGOFSET)
-               panic("_bus_dmamem_unmap");
-#endif
-
        /*
         * Nothing to do if we mapped it with KSEG0 or KSEG1 (i.e.
         * not in KSEG2).
@@ -704,10 +614,7 @@
            kva < (void *)MIPS_KSEG2_START)
                return;
 
-       size = round_page(size);
-       pmap_remove(pmap_kernel(), (vaddr_t)kva, (vaddr_t)kva + size);
-       pmap_update(pmap_kernel());
-       uvm_km_free(kernel_map, (vaddr_t)kva, size, UVM_KMF_VAONLY);
+       _bus_dmamem_unmap_common(t, kva, size);
 }
 
 /*
@@ -718,26 +625,11 @@
 _bus_dmamem_mmap(bus_dma_tag_t t, bus_dma_segment_t *segs, int nsegs,
     off_t off, int prot, int flags)
 {
-       int i;
+       bus_addr_t rv;
 
-       for (i = 0; i < nsegs; i++) {
-#ifdef DIAGNOSTIC
-               if (off & PGOFSET)
-                       panic("_bus_dmamem_mmap: offset unaligned");
-               if (segs[i].ds_addr & PGOFSET)
-                       panic("_bus_dmamem_mmap: segment unaligned");
-               if (segs[i].ds_len & PGOFSET)
-                       panic("_bus_dmamem_mmap: segment size not multiple"
-                           " of page size");
-#endif
-               if (off >= segs[i].ds_len) {
-                       off -= segs[i].ds_len;
-                       continue;
-               }
-
-               return (mips_btop((char *)segs[i].ds_addr + off));
-       }
-
-       /* Page not found. */
-       return (-1);
+       rv = _bus_dmamem_mmap_common(t, segs, nsegs, off, prot, flags);
+       if (rv == (bus_addr_t)-1)
+               return (-1);
+       
+       return (mips_btop((char *)rv));
 }
diff -r 12e705017f3c -r 7dd600edcf27 sys/arch/algor/conf/files.algor
--- a/sys/arch/algor/conf/files.algor   Fri Aug 21 03:39:41 2009 +0000
+++ b/sys/arch/algor/conf/files.algor   Fri Aug 21 03:45:10 2009 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: files.algor,v 1.25 2009/08/11 03:37:26 matt Exp $
+#      $NetBSD: files.algor,v 1.26 2009/08/21 03:45:10 thorpej Exp $
 
 # Algorithmics evaluation board specific configuration info.
 
@@ -45,6 +45,8 @@
 file   arch/mips/mips/mips3_clock.c
 file   arch/mips/mips/mips3_clockintr.c
 
+file   common/bus_dma/bus_dmamem_common.c
+
 #
 # The autoconfiguration root.
 #
diff -r 12e705017f3c -r 7dd600edcf27 sys/arch/cobalt/cobalt/bus.c
--- a/sys/arch/cobalt/cobalt/bus.c      Fri Aug 21 03:39:41 2009 +0000
+++ b/sys/arch/cobalt/cobalt/bus.c      Fri Aug 21 03:45:10 2009 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: bus.c,v 1.36 2009/08/20 11:50:11 tsutsui Exp $ */
+/*     $NetBSD: bus.c,v 1.37 2009/08/21 03:50:01 thorpej Exp $ */
 
 /*
  * Copyright (c) 1998 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: bus.c,v 1.36 2009/08/20 11:50:11 tsutsui Exp $");
+__KERNEL_RCSID(0, "$NetBSD: bus.c,v 1.37 2009/08/21 03:50:01 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -44,6 +44,8 @@
 #define _COBALT_BUS_DMA_PRIVATE
 #include <machine/bus.h>
 
+#include <common/bus_dma/bus_dmamem_common.h>
+
 #include <uvm/uvm_extern.h>
 
 #include <mips/cache.h>
@@ -603,57 +605,11 @@
     int flags)
 {
        extern paddr_t avail_start, avail_end;
-       vaddr_t curaddr, lastaddr;
-       psize_t high;
-       struct vm_page *m;
-       struct pglist mlist;
-       int curseg, error;
 
-       /* Always round the size. */
-       size = round_page(size);
-
-       high = avail_end - PAGE_SIZE;
-
-       /*
-        * Allocate pages from the VM system.
-        */
-       error = uvm_pglistalloc(size, avail_start, high, alignment, boundary,
-           &mlist, nsegs, (flags & BUS_DMA_NOWAIT) == 0);
-       if (error)
-               return error;
-
-       /*
-        * Compute the location, size, and number of segments actually
-        * returned by the VM code.
-        */
-       m = mlist.tqh_first;
-       curseg = 0;
-       lastaddr = segs[curseg].ds_addr = VM_PAGE_TO_PHYS(m);
-       segs[curseg].ds_len = PAGE_SIZE;
-       m = m->pageq.queue.tqe_next;
-
-       for (; m != NULL; m = m->pageq.queue.tqe_next) {
-               curaddr = VM_PAGE_TO_PHYS(m);
-#ifdef DIAGNOSTIC
-               if (curaddr < avail_start || curaddr >= high) {
-                       printf("uvm_pglistalloc returned non-sensical"
-                           " address 0x%lx\n", curaddr);
-                       panic("_bus_dmamem_alloc");
-               }
-#endif



Home | Main Index | Thread Index | Old Index