Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/acpi Add a XXX-comment as a TODO. From jmcneill@:



details:   https://anonhg.NetBSD.org/src/rev/03c134ee6b5a
branches:  trunk
changeset: 757003:03c134ee6b5a
user:      jruoho <jruoho%NetBSD.org@localhost>
date:      Tue Aug 10 04:38:06 2010 +0000

description:
Add a XXX-comment as a TODO. From jmcneill@:

        /*
         * XXX: The pci_find_device(9) function only deals with
         *      attached devices. Change this to use something like
         *      pci_device_foreach(), and implement it for IA-64.
         */

diffstat:

 sys/dev/acpi/acpi_cpu_cstate.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (30 lines):

diff -r 581086275f5f -r 03c134ee6b5a sys/dev/acpi/acpi_cpu_cstate.c
--- a/sys/dev/acpi/acpi_cpu_cstate.c    Tue Aug 10 02:43:50 2010 +0000
+++ b/sys/dev/acpi/acpi_cpu_cstate.c    Tue Aug 10 04:38:06 2010 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: acpi_cpu_cstate.c,v 1.19 2010/08/10 02:42:05 jruoho Exp $ */
+/* $NetBSD: acpi_cpu_cstate.c,v 1.20 2010/08/10 04:38:06 jruoho Exp $ */
 
 /*-
  * Copyright (c) 2010 Jukka Ruohonen <jruohonen%iki.fi@localhost>
@@ -27,7 +27,7 @@
  * SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: acpi_cpu_cstate.c,v 1.19 2010/08/10 02:42:05 jruoho Exp $");
+__KERNEL_RCSID(0, "$NetBSD: acpi_cpu_cstate.c,v 1.20 2010/08/10 04:38:06 jruoho Exp $");
 
 #include <sys/param.h>
 #include <sys/cpu.h>
@@ -630,6 +630,11 @@
 acpicpu_cstate_quirks_piix4(struct pci_attach_args *pa)
 {
 
+       /*
+        * XXX: The pci_find_device(9) function only deals with
+        *      attached devices. Change this to use something like
+        *      pci_device_foreach(), and implement it for IA-64.
+        */
        if (PCI_VENDOR(pa->pa_id) != PCI_VENDOR_INTEL)
                return 0;
 



Home | Main Index | Thread Index | Old Index