Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.sbin/puffs/mount_psshfs Don't allow mangling of uid or g...



details:   https://anonhg.NetBSD.org/src/rev/d6f571cbe9a1
branches:  trunk
changeset: 750593:d6f571cbe9a1
user:      pooka <pooka%NetBSD.org@localhost>
date:      Thu Jan 07 21:23:10 2010 +0000

description:
Don't allow mangling of uid or gid -1, since they have a special
meaning in the sftp protocol.

diffstat:

 usr.sbin/puffs/mount_psshfs/psshfs.c |  10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diffs (38 lines):

diff -r 5e5dcf8de50a -r d6f571cbe9a1 usr.sbin/puffs/mount_psshfs/psshfs.c
--- a/usr.sbin/puffs/mount_psshfs/psshfs.c      Thu Jan 07 21:19:45 2010 +0000
+++ b/usr.sbin/puffs/mount_psshfs/psshfs.c      Thu Jan 07 21:23:10 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: psshfs.c,v 1.56 2010/01/07 21:05:50 pooka Exp $        */
+/*     $NetBSD: psshfs.c,v 1.57 2010/01/07 21:23:10 pooka Exp $        */
 
 /*
  * Copyright (c) 2006-2009  Antti Kantee.  All Rights Reserved.
@@ -41,7 +41,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: psshfs.c,v 1.56 2010/01/07 21:05:50 pooka Exp $");
+__RCSID("$NetBSD: psshfs.c,v 1.57 2010/01/07 21:23:10 pooka Exp $");
 #endif /* !lint */
 
 #include <sys/types.h>
@@ -157,6 +157,9 @@
                case 'g':
                        pctx.domanglegid = 1;
                        pctx.manglegid = atoi(optarg);
+                       if (pctx.manglegid == (gid_t)-1)
+                               errx(1, "%s: -1 not allowed for -g",
+                                   getprogname());
                        pctx.mygid = getegid();
                        break;
                case 'O':
@@ -186,6 +189,9 @@
                case 'u':
                        pctx.domangleuid = 1;
                        pctx.mangleuid = atoi(optarg);
+                       if (pctx.mangleuid == (uid_t)-1)
+                               errx(1, "%s: -1 not allowed for -u",
+                                   getprogname());
                        pctx.myuid = geteuid();
                        break;
                default:



Home | Main Index | Thread Index | Old Index