Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/msdosfs * Don't care about VOP_CLOSE() error in unmou...



details:   https://anonhg.NetBSD.org/src/rev/8b89bdb5fc16
branches:  trunk
changeset: 753707:8b89bdb5fc16
user:      pooka <pooka%NetBSD.org@localhost>
date:      Wed Apr 07 15:19:09 2010 +0000

description:
* Don't care about VOP_CLOSE() error in unmount.  In the extremely
  unlike event it did fail, the kernel would double lutz to doom
  (in failure devvp now remains unmountable until reboot.  fans
  of complicated & untested error branches may attempt to gunk this
  up.  i'm not one of them).
* cosmetic surgery: cut extra ;

diffstat:

 sys/fs/msdosfs/msdosfs_vfsops.c |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (44 lines):

diff -r 5603a4e830be -r 8b89bdb5fc16 sys/fs/msdosfs/msdosfs_vfsops.c
--- a/sys/fs/msdosfs/msdosfs_vfsops.c   Wed Apr 07 14:53:52 2010 +0000
+++ b/sys/fs/msdosfs/msdosfs_vfsops.c   Wed Apr 07 15:19:09 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: msdosfs_vfsops.c,v 1.79 2010/01/31 10:30:40 mlelstv Exp $      */
+/*     $NetBSD: msdosfs_vfsops.c,v 1.80 2010/04/07 15:19:09 pooka Exp $        */
 
 /*-
  * Copyright (C) 1994, 1995, 1997 Wolfgang Solfrank.
@@ -48,7 +48,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: msdosfs_vfsops.c,v 1.79 2010/01/31 10:30:40 mlelstv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: msdosfs_vfsops.c,v 1.80 2010/04/07 15:19:09 pooka Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_compat_netbsd.h"
@@ -811,7 +811,7 @@
 
        return (0);
 
-error_exit:;
+error_exit:
        if (bp)
                brelse(bp, BC_AGE);
        if (pmp) {
@@ -871,14 +871,14 @@
        }
 #endif
        vn_lock(pmp->pm_devvp, LK_EXCLUSIVE | LK_RETRY);
-       error = VOP_CLOSE(pmp->pm_devvp,
+       (void) VOP_CLOSE(pmp->pm_devvp,
            pmp->pm_flags & MSDOSFSMNT_RONLY ? FREAD : FREAD|FWRITE, NOCRED);
        vput(pmp->pm_devvp);
        free(pmp->pm_inusemap, M_MSDOSFSFAT);
        free(pmp, M_MSDOSFSMNT);
        mp->mnt_data = NULL;
        mp->mnt_flag &= ~MNT_LOCAL;
-       return (error);
+       return (0);
 }
 
 int



Home | Main Index | Thread Index | Old Index