Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Fix memory barrier in a debug function



details:   https://anonhg.NetBSD.org/src/rev/e62105579ac5
branches:  trunk
changeset: 750626:e62105579ac5
user:      martin <martin%NetBSD.org@localhost>
date:      Fri Jan 08 16:40:30 2010 +0000

description:
Fix memory barrier in a debug function

diffstat:

 sys/dev/usb/ohci.c |  9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diffs (33 lines):

diff -r 8876bfaff250 -r e62105579ac5 sys/dev/usb/ohci.c
--- a/sys/dev/usb/ohci.c        Fri Jan 08 16:37:39 2010 +0000
+++ b/sys/dev/usb/ohci.c        Fri Jan 08 16:40:30 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ohci.c,v 1.203 2009/11/12 19:49:03 dyoung Exp $        */
+/*     $NetBSD: ohci.c,v 1.204 2010/01/08 16:40:30 martin Exp $        */
 /*     $FreeBSD: src/sys/dev/usb/ohci.c,v 1.22 1999/11/17 22:33:40 n_hibma Exp $       */
 
 /*
@@ -41,7 +41,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.203 2009/11/12 19:49:03 dyoung Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.204 2010/01/08 16:40:30 martin Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1979,12 +1979,11 @@
 {
        char sbuf[128];
 
+       usb_syncmem(&std->dma, std->offs, sizeof(std->td),
+           BUS_DMASYNC_POSTWRITE | BUS_DMASYNC_POSTREAD);
        snprintb(sbuf, sizeof(sbuf),
            "\20\23R\24OUT\25IN\31TOG1\32SETTOGGLE",
            (u_int32_t)O32TOH(std->td.td_flags));
-
-       usb_syncmem(&std->dma, std->offs, sizeof(std->td),
-           BUS_DMASYNC_POSTWRITE | BUS_DMASYNC_POSTREAD);
        printf("TD(%p) at %08lx: %s delay=%d ec=%d cc=%d\ncbp=0x%08lx "
               "nexttd=0x%08lx be=0x%08lx\n",
               std, (u_long)std->physaddr, sbuf,



Home | Main Index | Thread Index | Old Index