Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libperfuse Fix uninitiaized variable usage (never though...



details:   https://anonhg.NetBSD.org/src/rev/c0319e1ffbd2
branches:  trunk
changeset: 768124:c0319e1ffbd2
user:      manu <manu%NetBSD.org@localhost>
date:      Tue Aug 09 09:06:52 2011 +0000

description:
Fix uninitiaized variable usage (never though lint would miss that when
used by return statement) that caused unprivilegied user to fail on
unlink(2) and rename(2) operations.

diffstat:

 lib/libperfuse/ops.c |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (31 lines):

diff -r 378300d240b6 -r c0319e1ffbd2 lib/libperfuse/ops.c
--- a/lib/libperfuse/ops.c      Tue Aug 09 08:36:05 2011 +0000
+++ b/lib/libperfuse/ops.c      Tue Aug 09 09:06:52 2011 +0000
@@ -1,4 +1,4 @@
-/*  $NetBSD: ops.c,v 1.37 2011/08/02 16:57:16 manu Exp $ */
+/*  $NetBSD: ops.c,v 1.38 2011/08/09 09:06:52 manu Exp $ */
 
 /*-
  *  Copyright (c) 2010-2011 Emmanuel Dreyfus. All rights reserved.
@@ -241,7 +241,7 @@
 {
        uid_t uid;
        struct puffs_node *tdir;
-       int sticky, owner, error;
+       int sticky, owner;
 
        tdir = PERFUSE_NODE_DATA(targ)->pnd_parent;
 
@@ -264,9 +264,9 @@
        owner = puffs_pn_getvap(targ)->va_uid == uid;
 
        if (sticky && !owner)
-               error = EACCES;
-
-       return error;   
+               return EACCES;
+
+       return 0;
 }
 
 



Home | Main Index | Thread Index | Old Index