Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/x86/include Change 'typedef void *pci_chipset_tag_t...



details:   https://anonhg.NetBSD.org/src/rev/82b1d9ee1725
branches:  trunk
changeset: 752381:82b1d9ee1725
user:      dyoung <dyoung%NetBSD.org@localhost>
date:      Wed Feb 24 21:24:20 2010 +0000

description:
Change 'typedef void *pci_chipset_tag_t' to 'typedef struct
pci_chipset_tag *pci_chipset_tag_t' for an improvement in type safety.
(Back when I did the same for cardbus_chipset_tag_t, it helped to turn
up some bugs!)

diffstat:

 sys/arch/x86/include/pci_machdep.h |  8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diffs (25 lines):

diff -r 0ebf3d901b4e -r 82b1d9ee1725 sys/arch/x86/include/pci_machdep.h
--- a/sys/arch/x86/include/pci_machdep.h        Wed Feb 24 21:22:01 2010 +0000
+++ b/sys/arch/x86/include/pci_machdep.h        Wed Feb 24 21:24:20 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pci_machdep.h,v 1.9 2010/02/16 00:03:47 dyoung Exp $   */
+/*     $NetBSD: pci_machdep.h,v 1.10 2010/02/24 21:24:20 dyoung Exp $  */
 
 /*
  * Copyright (c) 1996 Christopher G. Demetriou.  All rights reserved.
@@ -71,10 +71,14 @@
 extern struct x86_bus_dma_tag pci_bus_dma64_tag;
 #endif
 
+struct {
+        int dummy;
+} pci_chipset_tag;
+
 /*
  * Types provided to machine-independent PCI code
  */
-typedef void *pci_chipset_tag_t;
+typedef struct pci_chipset_tag *pci_chipset_tag_t;
 typedef union x86_pci_tag_u pcitag_t;
 typedef int pci_intr_handle_t;
 



Home | Main Index | Thread Index | Old Index