[src/trunk]: src Add a small test that checks that random(3) does not always ...

[jruoho <jruoho%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/34f30a98ba7e
branches:  trunk
changeset: 778467:34f30a98ba7e
user:      jruoho <jruoho%NetBSD.org@localhost>
date:      Wed Mar 28 10:33:57 2012 +0000

description:
Add a small test that checks that random(3) does not always return zero when
the RNG is initialized with zero. Prompoted by the recent nasty bug in the
OpenBSD libc.

diffstat:

 distrib/sets/lists/tests/mi      |   4 +-
 tests/lib/libc/stdlib/Makefile   |   3 +-
 tests/lib/libc/stdlib/t_random.c |  72 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 77 insertions(+), 2 deletions(-)

diffs (118 lines):

diff -r ba8a2d336eda -r 34f30a98ba7e distrib/sets/lists/tests/mi
--- a/distrib/sets/lists/tests/mi       Wed Mar 28 10:22:46 2012 +0000
+++ b/distrib/sets/lists/tests/mi       Wed Mar 28 10:33:57 2012 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.458 2012/03/27 08:16:33 jruoho Exp $
+# $NetBSD: mi,v 1.459 2012/03/28 10:33:57 jruoho Exp $
 #
 # Note: don't delete entries from here - mark them as "obsolete" instead.
 #
@@ -495,6 +495,7 @@
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_hsearch.debug          tests-lib-debug         debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_mi_vector_hash.debug   tests-lib-debug         debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_posix_memalign.debug   tests-lib-debug         debug,atf
+./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_random.debug           tests-lib-debug         debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtod.debug           tests-lib-debug         debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtol.debug           tests-lib-debug         debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtox.debug           tests-obsolete          obsolete
@@ -2387,6 +2388,7 @@
 ./usr/tests/lib/libc/stdlib/t_hsearch          tests-lib-tests         atf
 ./usr/tests/lib/libc/stdlib/t_mi_vector_hash   tests-lib-tests         atf
 ./usr/tests/lib/libc/stdlib/t_posix_memalign   tests-lib-tests         atf
+./usr/tests/lib/libc/stdlib/t_random           tests-lib-tests         atf
 ./usr/tests/lib/libc/stdlib/t_strtod           tests-lib-tests         atf
 ./usr/tests/lib/libc/stdlib/t_strtol           tests-lib-tests         atf
 ./usr/tests/lib/libc/stdlib/t_strtox           tests-obsolete          obsolete
diff -r ba8a2d336eda -r 34f30a98ba7e tests/lib/libc/stdlib/Makefile
--- a/tests/lib/libc/stdlib/Makefile    Wed Mar 28 10:22:46 2012 +0000
+++ b/tests/lib/libc/stdlib/Makefile    Wed Mar 28 10:33:57 2012 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.19 2012/02/24 14:02:55 joerg Exp $
+# $NetBSD: Makefile,v 1.20 2012/03/28 10:33:57 jruoho Exp $
 
 .include <bsd.own.mk>
 
@@ -11,6 +11,7 @@
 TESTS_C+=      t_hsearch
 TESTS_C+=      t_mi_vector_hash
 TESTS_C+=      t_posix_memalign
+TESTS_C+=      t_random
 TESTS_C+=      t_strtod
 TESTS_C+=      t_strtol
 TESTS_C+=      t_system
diff -r ba8a2d336eda -r 34f30a98ba7e tests/lib/libc/stdlib/t_random.c
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tests/lib/libc/stdlib/t_random.c  Wed Mar 28 10:33:57 2012 +0000
@@ -0,0 +1,72 @@
+/* $NetBSD: t_random.c,v 1.1 2012/03/28 10:33:57 jruoho Exp $ */
+
+/*-
+ * Copyright (c) 2012 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software contributed to The NetBSD Foundation
+ * by Jukka Ruohonen.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+#include <sys/cdefs.h>
+__RCSID("$NetBSD: t_random.c,v 1.1 2012/03/28 10:33:57 jruoho Exp $");
+
+#include <atf-c.h>
+#include <stdlib.h>
+
+/*
+ * TODO: Add some general RNG tests (cf. the famous "diehard" tests?).
+ */
+
+ATF_TC(random_zero);
+ATF_TC_HEAD(random_zero, tc)
+{
+       atf_tc_set_md_var(tc, "descr",
+           "Test that random(3) does not always return "
+           "zero when the seed is initialized to zero");
+}
+
+ATF_TC_BODY(random_zero, tc)
+{
+       const size_t n = 1000000;
+       size_t i, j;
+       long x;
+
+       srandom(0);
+
+       for (i = j = 0; i < n; i++) {
+
+               if ((x = random()) == 0)
+                       j++;
+       }
+
+       ATF_REQUIRE(j != n);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+       ATF_TP_ADD_TC(tp, random_zero);
+
+       return atf_no_error();
+}