Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Don't notify about zero length reads without UCO...



details:   https://anonhg.NetBSD.org/src/rev/58b912d5d453
branches:  trunk
changeset: 772735:58b912d5d453
user:      jakllsch <jakllsch%NetBSD.org@localhost>
date:      Sat Jan 14 20:41:49 2012 +0000

description:
Don't notify about zero length reads without UCOM_DEBUG && ucomdebug > 0.
It's typical for uslsa(4) hardware to do this occasionally.

diffstat:

 sys/dev/usb/ucom.c |  12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diffs (34 lines):

diff -r 7ba6ec12bbfe -r 58b912d5d453 sys/dev/usb/ucom.c
--- a/sys/dev/usb/ucom.c        Sat Jan 14 20:25:45 2012 +0000
+++ b/sys/dev/usb/ucom.c        Sat Jan 14 20:41:49 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ucom.c,v 1.94 2012/01/14 20:25:45 jakllsch Exp $       */
+/*     $NetBSD: ucom.c,v 1.95 2012/01/14 20:41:49 jakllsch Exp $       */
 
 /*
  * Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.94 2012/01/14 20:25:45 jakllsch Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.95 2012/01/14 20:41:49 jakllsch Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1246,10 +1246,12 @@
 
        usbd_get_xfer_status(xfer, NULL, (void *)&cp, &cc, NULL);
 
-       if (cc == 0) {
-               aprint_normal_dev(sc->sc_dev,
-                   "ucomreadcb: zero length xfer!\n");
+#ifdef UCOM_DEBUG
+       /* This is triggered by uslsa(4) occasionally. */
+       if ((ucomdebug > 0) && (cc == 0)) {
+               device_printf(sc->sc_dev, "ucomreadcb: zero length xfer!\n");
        }
+#endif
 
        KDASSERT(cp == ub->ub_data);
 



Home | Main Index | Thread Index | Old Index