Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/ufs/ufs ok, it is clear that at least vput(vp) needs to ...



details:   https://anonhg.NetBSD.org/src/rev/f502778a4b0a
branches:  trunk
changeset: 767415:f502778a4b0a
user:      dholland <dholland%NetBSD.org@localhost>
date:      Mon Jul 18 02:35:11 2011 +0000

description:
ok, it is clear that at least vput(vp) needs to go before fstrans_done().
I hoping vput(dvp) doesn't, because if it does that will vastly complicate
future vfs locking cleanup.

diffstat:

 sys/ufs/ufs/ufs_vnops.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (29 lines):

diff -r 4e7014190cf6 -r f502778a4b0a sys/ufs/ufs/ufs_vnops.c
--- a/sys/ufs/ufs/ufs_vnops.c   Mon Jul 18 02:14:01 2011 +0000
+++ b/sys/ufs/ufs/ufs_vnops.c   Mon Jul 18 02:35:11 2011 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ufs_vnops.c,v 1.197 2011/07/18 01:52:55 dholland Exp $ */
+/*     $NetBSD: ufs_vnops.c,v 1.198 2011/07/18 02:35:11 dholland Exp $ */
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -66,7 +66,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ufs_vnops.c,v 1.197 2011/07/18 01:52:55 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ufs_vnops.c,v 1.198 2011/07/18 02:35:11 dholland Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_ffs.h"
@@ -1763,9 +1763,9 @@
 #endif
  out:
        VN_KNOTE(vp, NOTE_DELETE);
+       vput(vp);
        fstrans_done(dvp->v_mount);
        vput(dvp);
-       vput(vp);
        return (error);
 }
 



Home | Main Index | Thread Index | Old Index