Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/ufs/ufs Temporary fix for quotactl authorization: it mus...



details:   https://anonhg.NetBSD.org/src/rev/5de0361b95f5
branches:  trunk
changeset: 781477:5de0361b95f5
user:      manu <manu%NetBSD.org@localhost>
date:      Sun Sep 09 04:27:49 2012 +0000

description:
Temporary fix for quotactl authorization: it must use the effective UID
and not the real UID.

Further work is required to move the check to the kauth listener instead
of having it in UFS code.

diffstat:

 sys/ufs/ufs/ufs_quota.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 5a7c23ea8bf8 -r 5de0361b95f5 sys/ufs/ufs/ufs_quota.c
--- a/sys/ufs/ufs/ufs_quota.c   Sun Sep 09 04:27:11 2012 +0000
+++ b/sys/ufs/ufs/ufs_quota.c   Sun Sep 09 04:27:49 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ufs_quota.c,v 1.111 2012/08/26 02:32:14 dholland Exp $ */
+/*     $NetBSD: ufs_quota.c,v 1.112 2012/09/09 04:27:49 manu Exp $     */
 
 /*
  * Copyright (c) 1982, 1986, 1990, 1993, 1995
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ufs_quota.c,v 1.111 2012/08/26 02:32:14 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ufs_quota.c,v 1.112 2012/09/09 04:27:49 manu Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_quota.h"
@@ -335,7 +335,7 @@
 static int
 quota_get_auth(struct mount *mp, struct lwp *l, uid_t id) {
        /* The user can always query about his own quota. */
-       if (id == kauth_cred_getuid(l->l_cred))
+       if (id == kauth_cred_geteuid(l->l_cred))
                return 0;
        return kauth_authorize_system(l->l_cred, KAUTH_SYSTEM_FS_QUOTA,
            KAUTH_REQ_SYSTEM_FS_QUOTA_GET, mp, KAUTH_ARG(id), NULL);



Home | Main Index | Thread Index | Old Index