Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/gpl3/binutils/dist/ld/emulparams XXX: This is a hac...



details:   https://anonhg.NetBSD.org/src/rev/f08aef795e8b
branches:  trunk
changeset: 754116:f08aef795e8b
user:      christos <christos%NetBSD.org@localhost>
date:      Tue Apr 20 22:47:48 2010 +0000

description:
XXX: This is a hack, the note inclusion does not belong here, and
it belongs in a separate elf_nbsd.sh, included from elf_i386_nbsd.sh.
The problem is described in:
https://bugzilla.redhat.com/show_bug.cgi?id=492183#c7, namely if
all the sections are not defined in the ld script, it can screw
up.  This happens when building /usr/src/usr.sbin.crash with
MKPIE=yes. Thanks to Piotr Meyer for the report and analysis.
We don't need to fix any other archs yet (because crash only works on i386),
but we should. skrll should look into it, please :-)

diffstat:

 external/gpl3/binutils/dist/ld/emulparams/elf_i386.sh |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diffs (8 lines):

diff -r 382ed79f7f1d -r f08aef795e8b external/gpl3/binutils/dist/ld/emulparams/elf_i386.sh
--- a/external/gpl3/binutils/dist/ld/emulparams/elf_i386.sh     Tue Apr 20 22:37:25 2010 +0000
+++ b/external/gpl3/binutils/dist/ld/emulparams/elf_i386.sh     Tue Apr 20 22:47:48 2010 +0000
@@ -12,3 +12,4 @@
 GENERATE_PIE_SCRIPT=yes
 NO_SMALL_DATA=yes
 SEPARATE_GOTPLT=12
+OTHER_SECTIONS=".note.netbsd.ident 0 : { KEEP(*(.note.netbsd.ident)); }"



Home | Main Index | Thread Index | Old Index