Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/bsd/bind/dist/lib/lwres Simplify ERR, so that it do...



details:   https://anonhg.NetBSD.org/src/rev/aca68c09d52d
branches:  trunk
changeset: 779749:aca68c09d52d
user:      joerg <joerg%NetBSD.org@localhost>
date:      Fri Jun 15 19:54:21 2012 +0000

description:
Simplify ERR, so that it doesn't mess up Clang's
-Wsometimes-uninitialized scan on the function. This is tracked in LLVM
as http://llvm.org/bugs/show_bug.cgi?id=13093.

diffstat:

 external/bsd/bind/dist/lib/lwres/getnameinfo.c |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diffs (24 lines):

diff -r 5634e26a92bd -r aca68c09d52d external/bsd/bind/dist/lib/lwres/getnameinfo.c
--- a/external/bsd/bind/dist/lib/lwres/getnameinfo.c    Fri Jun 15 19:20:44 2012 +0000
+++ b/external/bsd/bind/dist/lib/lwres/getnameinfo.c    Fri Jun 15 19:54:21 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: getnameinfo.c,v 1.3 2012/06/05 00:43:04 christos Exp $ */
+/*     $NetBSD: getnameinfo.c,v 1.4 2012/06/15 19:54:21 joerg Exp $    */
 
 /*
  * Portions Copyright (C) 2004, 2005, 2007, 2011, 2012  Internet Systems Consortium, Inc. ("ISC")
@@ -149,13 +149,9 @@
 #define ENI_SALEN      6
 #define ENI_NOSOCKET   7
 
-/*!
- * The test against 0 is there to keep the Solaris compiler
- * from complaining about "end-of-loop code not reached".
- */
 #define ERR(code) \
        do { result = (code);                   \
-               if (result != 0) goto cleanup;  \
+               goto cleanup;                   \
        } while (/*CONSTCOND*/0)
 
 /*% lightweight resolver socket address structure to hostname and service name */



Home | Main Index | Thread Index | Old Index