[src/trunk]: src/sys/dev/iscsi assemble_login_parameters() has a strange erro...

[martin <martin%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/affe6bac083e
branches:  trunk
changeset: 779799:affe6bac083e
user:      martin <martin%NetBSD.org@localhost>
date:      Tue Jun 19 14:19:46 2012 +0000

description:
assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.

diffstat:

 sys/dev/iscsi/iscsi_send.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r fde46e4bbbae -r affe6bac083e sys/dev/iscsi/iscsi_send.c
--- a/sys/dev/iscsi/iscsi_send.c        Tue Jun 19 13:44:35 2012 +0000
+++ b/sys/dev/iscsi/iscsi_send.c        Tue Jun 19 14:19:46 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: iscsi_send.c,v 1.3 2012/06/09 06:19:58 mlelstv Exp $   */
+/*     $NetBSD: iscsi_send.c,v 1.4 2012/06/19 14:19:46 martin Exp $    */
 
 /*-
  * Copyright (c) 2004,2005,2006,2011 The NetBSD Foundation, Inc.
@@ -1113,7 +1113,7 @@
                return conn->terminating;
        }
 
-       if ((rc = assemble_login_parameters(conn, ccb, pdu)) >= 0) {
+       if ((rc = assemble_login_parameters(conn, ccb, pdu)) <= 0) {
                init_login_pdu(conn, pdu, !rc);
                setup_tx_uio(pdu, pdu->temp_data_len, pdu->temp_data, FALSE);
                send_pdu(ccb, pdu, CCBDISP_WAIT, PDUDISP_FREE);