Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev ensure that the intr lock is held for all audio_clea...



details:   https://anonhg.NetBSD.org/src/rev/f56108ebfb76
branches:  trunk
changeset: 779073:f56108ebfb76
user:      mrg <mrg%NetBSD.org@localhost>
date:      Mon Apr 30 02:16:46 2012 +0000

description:
ensure that the intr lock is held for all audio_clear() callers.

diffstat:

 sys/dev/audio.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (37 lines):

diff -r ae1399d6587e -r f56108ebfb76 sys/dev/audio.c
--- a/sys/dev/audio.c   Mon Apr 30 00:08:03 2012 +0000
+++ b/sys/dev/audio.c   Mon Apr 30 02:16:46 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: audio.c,v 1.260 2012/04/06 06:15:13 mrg Exp $  */
+/*     $NetBSD: audio.c,v 1.261 2012/04/30 02:16:46 mrg Exp $  */
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -155,7 +155,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: audio.c,v 1.260 2012/04/06 06:15:13 mrg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: audio.c,v 1.261 2012/04/30 02:16:46 mrg Exp $");
 
 #include "audio.h"
 #if NAUDIO > 0
@@ -1991,7 +1991,7 @@
 audio_clear(struct audio_softc *sc)
 {
 
-       KASSERT(mutex_owned(sc->sc_lock));
+       KASSERT(mutex_owned(sc->sc_intr_lock));
 
        if (sc->sc_rbus) {
                cv_broadcast(&sc->sc_rchan);
@@ -2387,8 +2387,8 @@
                DPRINTF(("AUDIO_FLUSH\n"));
                rbus = sc->sc_rbus;
                pbus = sc->sc_pbus;
+               mutex_enter(sc->sc_intr_lock);
                audio_clear(sc);
-               mutex_enter(sc->sc_intr_lock);
                error = audio_initbufs(sc);
                if (error) {
                        mutex_exit(sc->sc_intr_lock);



Home | Main Index | Thread Index | Old Index