Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/uebayasi-xip]: src/sys/miscfs/genfs Fix UVMHIST build.



details:   https://anonhg.NetBSD.org/src/rev/fe3ac9930e3a
branches:  uebayasi-xip
changeset: 751785:fe3ac9930e3a
user:      uebayasi <uebayasi%NetBSD.org@localhost>
date:      Wed Aug 25 14:29:12 2010 +0000

description:
Fix UVMHIST build.

Remove a comment about xip getpages optimization; quick profiling showed
that this routine is not expensive.  It'd be better to concentrate on
reducing TLB miss.

diffstat:

 sys/miscfs/genfs/genfs_io.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (35 lines):

diff -r 184c948858bf -r fe3ac9930e3a sys/miscfs/genfs/genfs_io.c
--- a/sys/miscfs/genfs/genfs_io.c       Wed Aug 25 14:23:16 2010 +0000
+++ b/sys/miscfs/genfs/genfs_io.c       Wed Aug 25 14:29:12 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: genfs_io.c,v 1.36.2.21 2010/08/17 06:47:36 uebayasi Exp $      */
+/*     $NetBSD: genfs_io.c,v 1.36.2.22 2010/08/25 14:29:12 uebayasi Exp $      */
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.21 2010/08/17 06:47:36 uebayasi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.22 2010/08/25 14:29:12 uebayasi Exp $");
 
 #include "opt_xip.h"
 
@@ -824,7 +824,6 @@
        if ((flags & PGO_LOCKED) == 0)
                mutex_exit(&uobj->vmobjlock);
 
-       /* XXX optimize */
        off = offset;
        for (i = 0; i < npages; i++) {
                daddr_t lbn, blkno;
@@ -867,7 +866,7 @@
 
                UVMHIST_LOG(ubchist, "xip pgs %d => phys_addr=0x%lx (%p)",
                        i,
-                       (long)pg->phys_addr,
+                       (long)pps[i]->phys_addr,
                        pps[i],
                        0);
 



Home | Main Index | Thread Index | Old Index