Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/uebayasi-xip]: src/sys/miscfs/genfs Clarify things a bit in XIP putpages.



details:   https://anonhg.NetBSD.org/src/rev/691d03069887
branches:  uebayasi-xip
changeset: 751902:691d03069887
user:      uebayasi <uebayasi%NetBSD.org@localhost>
date:      Sun Nov 21 18:22:32 2010 +0000

description:
Clarify things a bit in XIP putpages.

diffstat:

 sys/miscfs/genfs/genfs_io.c |  12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)

diffs (36 lines):

diff -r 723fb233274b -r 691d03069887 sys/miscfs/genfs/genfs_io.c
--- a/sys/miscfs/genfs/genfs_io.c       Sun Nov 21 17:07:38 2010 +0000
+++ b/sys/miscfs/genfs/genfs_io.c       Sun Nov 21 18:22:32 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: genfs_io.c,v 1.36.2.63 2010/11/21 17:07:38 uebayasi Exp $      */
+/*     $NetBSD: genfs_io.c,v 1.36.2.64 2010/11/21 18:22:32 uebayasi Exp $      */
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.63 2010/11/21 17:07:38 uebayasi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.64 2010/11/21 18:22:32 uebayasi Exp $");
 
 #include "opt_xip.h"
 
@@ -1532,16 +1532,10 @@
                mutex_enter(&uobj->vmobjlock);
                for (i = 0; i < npages; i++) {
                        pg = pgs[i];
-                       if (pg == NULL || pg == PGO_DONTCARE)
-                               continue;
+                       KASSERT(pg != NULL && pg != PGO_DONTCARE);
                        if (pg == PGO_HOLE) {
                                pg = uvm_page_holepage;
                                KASSERT(pg != NULL);
-                               /*
-                                * XXXUEBS
-                                * Invalidating hole pages may be unnecessary,
-                                * but just for safety.
-                                */
                        } else {
                                /*
                                 * Freeing normal XIP pages; nothing to do.



Home | Main Index | Thread Index | Old Index