Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src Three simple unit tests for revoke(2).



details:   https://anonhg.NetBSD.org/src/rev/570fb8b72f71
branches:  trunk
changeset: 766902:570fb8b72f71
user:      jruoho <jruoho%NetBSD.org@localhost>
date:      Sun Jul 03 21:06:56 2011 +0000

description:
Three simple unit tests for revoke(2).

diffstat:

 distrib/sets/lists/tests/mi |    4 +-
 tests/syscall/Makefile      |    4 +-
 tests/syscall/t_revoke.c    |  185 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 190 insertions(+), 3 deletions(-)

diffs (232 lines):

diff -r 41a70cd68644 -r 570fb8b72f71 distrib/sets/lists/tests/mi
--- a/distrib/sets/lists/tests/mi       Sun Jul 03 20:36:34 2011 +0000
+++ b/distrib/sets/lists/tests/mi       Sun Jul 03 21:06:56 2011 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.359 2011/07/03 17:47:15 jruoho Exp $
+# $NetBSD: mi,v 1.360 2011/07/03 21:06:56 jruoho Exp $
 #
 # Note: don't delete entries from here - mark them as "obsolete" instead.
 #
@@ -642,6 +642,7 @@
 ./usr/libdata/debug/usr/tests/syscall/t_poll.debug                     tests-syscall-debug     debug,atf
 ./usr/libdata/debug/usr/tests/syscall/t_pollts.debug                   tests-syscall-debug     debug,atf
 ./usr/libdata/debug/usr/tests/syscall/t_pselect.debug                  tests-syscall-debug     debug,atf
+./usr/libdata/debug/usr/tests/syscall/t_revoke.debug                   tests-syscall-debug     debug,atf
 ./usr/libdata/debug/usr/tests/syscall/t_setrlimit.debug                        tests-syscall-debug     debug,atf
 ./usr/libdata/debug/usr/tests/syscall/t_setuid.debug                   tests-syscall-debug     debug,atf
 ./usr/libdata/debug/usr/tests/syscall/t_stat.debug                     tests-syscall-debug     debug,atf
@@ -2391,6 +2392,7 @@
 ./usr/tests/syscall/t_poll                     tests-syscall-tests     atf
 ./usr/tests/syscall/t_pollts                   tests-syscall-tests     atf
 ./usr/tests/syscall/t_pselect                  tests-syscall-tests     atf
+./usr/tests/syscall/t_revoke                   tests-syscall-tests     atf
 ./usr/tests/syscall/t_setrlimit                        tests-syscall-tests     atf
 ./usr/tests/syscall/t_setuid                   tests-syscall-tests     atf
 ./usr/tests/syscall/t_stat                     tests-syscall-tests     atf
diff -r 41a70cd68644 -r 570fb8b72f71 tests/syscall/Makefile
--- a/tests/syscall/Makefile    Sun Jul 03 20:36:34 2011 +0000
+++ b/tests/syscall/Makefile    Sun Jul 03 21:06:56 2011 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.36 2011/07/03 17:47:15 jruoho Exp $
+# $NetBSD: Makefile,v 1.37 2011/07/03 21:06:56 jruoho Exp $
 
 .include <bsd.own.mk>
 
@@ -9,7 +9,7 @@
 TESTS_C+=      t_getrusage t_getsid t_gettimeofday
 TESTS_C+=      t_itimer t_kill t_link
 TESTS_C+=      t_mincore t_mknod t_mmap t_mprotect t_msync t_nanosleep
-TESTS_C+=      t_poll t_pollts t_pselect
+TESTS_C+=      t_poll t_pollts t_pselect t_revoke
 TESTS_C+=      t_setrlimit t_setuid t_stat t_timer t_truncate
 TESTS_C+=      t_umask t_unlink
 
diff -r 41a70cd68644 -r 570fb8b72f71 tests/syscall/t_revoke.c
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tests/syscall/t_revoke.c  Sun Jul 03 21:06:56 2011 +0000
@@ -0,0 +1,185 @@
+/* $NetBSD: t_revoke.c,v 1.1 2011/07/03 21:06:56 jruoho Exp $ */
+
+/*-
+ * Copyright (c) 2011 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software contributed to The NetBSD Foundation
+ * by Jukka Ruohonen.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+#include <sys/cdefs.h>
+__RCSID("$NetBSD: t_revoke.c,v 1.1 2011/07/03 21:06:56 jruoho Exp $");
+
+#include <sys/resource.h>
+#include <sys/wait.h>
+
+#include <atf-c.h>
+#include <fcntl.h>
+#include <errno.h>
+#include <pwd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+
+static const char path[] = "revoke";
+
+ATF_TC_WITH_CLEANUP(revoke_basic);
+ATF_TC_HEAD(revoke_basic, tc)
+{
+       atf_tc_set_md_var(tc, "descr", "A basic test of revoke(2)");
+}
+
+ATF_TC_BODY(revoke_basic, tc)
+{
+       struct rlimit res;
+       char tmp[10];
+       size_t i, n;
+       int *buf;
+
+       (void)memset(&res, 0, sizeof(struct rlimit));
+       (void)getrlimit(RLIMIT_NOFILE, &res);
+
+       if ((n = res.rlim_cur / 10) == 0)
+               n = 10;
+
+       buf = calloc(n, sizeof(int));
+       ATF_REQUIRE(buf != NULL);
+
+       buf[0] = open(path, O_RDWR | O_CREAT, 0600);
+       ATF_REQUIRE(buf[0] >= 0);
+
+       for (i = 1; i < n; i++) {
+               buf[i] = open(path, O_RDWR);
+               ATF_REQUIRE(buf[i] >= 0);
+       }
+
+       ATF_REQUIRE(revoke(path) == 0);
+
+       for (i = 0; i < n; i++) {
+
+               ATF_REQUIRE(read(buf[i], tmp, sizeof(tmp)) == -1);
+
+               (void)close(buf[i]);
+       }
+
+       free(buf);
+
+       (void)unlink(path);
+}
+
+ATF_TC_CLEANUP(revoke_basic, tc)
+{
+       (void)unlink(path);
+}
+
+ATF_TC(revoke_err);
+ATF_TC_HEAD(revoke_err, tc)
+{
+       atf_tc_set_md_var(tc, "descr", "Test errors from revoke(2)");
+}
+
+ATF_TC_BODY(revoke_err, tc)
+{
+       char buf[1024 + 1];     /* XXX: From the manual page... */
+
+       (void)memset(buf, 'x', sizeof(buf));
+
+       errno = 0;
+       ATF_REQUIRE_ERRNO(EFAULT, revoke((char *)-1) == -1);
+
+       errno = 0;
+       ATF_REQUIRE_ERRNO(ENAMETOOLONG, revoke(buf) == -1);
+
+       errno = 0;
+       ATF_REQUIRE_ERRNO(EPERM, revoke("/etc/passwd") == -1);
+
+       errno = 0;
+       ATF_REQUIRE_ERRNO(ENOENT, revoke("/etc/xxx/yyy") == -1);
+}
+
+ATF_TC_WITH_CLEANUP(revoke_perm);
+ATF_TC_HEAD(revoke_perm, tc)
+{
+       atf_tc_set_md_var(tc, "descr", "Test permissions revoke(2)");
+       atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(revoke_perm, tc)
+{
+       struct passwd *pw;
+       int fd, sta;
+       pid_t pid;
+
+       pw = getpwnam("nobody");
+       fd = open(path, O_RDWR | O_CREAT, 0600);
+
+       ATF_REQUIRE(fd >= 0);
+       ATF_REQUIRE(pw != NULL);
+       ATF_REQUIRE(revoke(path) == 0);
+
+       pid = fork();
+       ATF_REQUIRE(pid >= 0);
+
+       if (pid == 0) {
+
+               if (setuid(pw->pw_uid) != 0)
+                       _exit(EXIT_FAILURE);
+
+               errno = 0;
+
+               if (revoke(path) == 0)
+                       _exit(EXIT_FAILURE);
+
+               if (errno != EACCES)
+                       _exit(EXIT_FAILURE);
+
+               if (close(fd) != 0)
+                       _exit(EXIT_FAILURE);
+
+               _exit(EXIT_SUCCESS);
+       }
+
+       (void)wait(&sta);
+
+       if (WIFEXITED(sta) == 0 || WEXITSTATUS(sta) != EXIT_SUCCESS)
+               atf_tc_fail("revoke(2) did not obey permissions");
+
+       ATF_REQUIRE(unlink(path) == 0);
+}
+
+ATF_TC_CLEANUP(revoke_perm, tc)
+{
+       (void)unlink(path);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+       ATF_TP_ADD_TC(tp, revoke_basic);
+       ATF_TP_ADD_TC(tp, revoke_err);
+       ATF_TP_ADD_TC(tp, revoke_perm);
+
+       return atf_no_error();
+}



Home | Main Index | Thread Index | Old Index