[src/trunk]: src/sys/dev/pci bnx_start() is not MP-safe, so do not create the...

[bouyer <bouyer%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/9c8a02934318
branches:  trunk
changeset: 777858:9c8a02934318
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Tue Mar 06 18:29:23 2012 +0000

description:
bnx_start() is not MP-safe, so do not create the bnx_alloc_pkts()'s
workqueue MPSAFE. This could lead to bnx_start() being running at
the same time on 2 CPUs, with packets being sent twice.
Problem found and reported by Beverly Schwartz and Greg Troxel.

diffstat:

 sys/dev/pci/if_bnx.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r c8fb7db9cfc9 -r 9c8a02934318 sys/dev/pci/if_bnx.c
--- a/sys/dev/pci/if_bnx.c      Tue Mar 06 17:20:38 2012 +0000
+++ b/sys/dev/pci/if_bnx.c      Tue Mar 06 18:29:23 2012 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_bnx.c,v 1.45 2011/09/22 08:42:53 jym Exp $  */
+/*     $NetBSD: if_bnx.c,v 1.46 2012/03/06 18:29:23 bouyer Exp $       */
 /*     $OpenBSD: if_bnx.c,v 1.85 2009/11/09 14:32:41 dlg Exp $ */
 
 /*-
@@ -35,7 +35,7 @@
 #if 0
 __FBSDID("$FreeBSD: src/sys/dev/bce/if_bce.c,v 1.3 2006/04/13 14:12:26 ru Exp $");
 #endif
-__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.45 2011/09/22 08:42:53 jym Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.46 2012/03/06 18:29:23 bouyer Exp $");
 
 /*
  * The following controllers are supported by this driver:
@@ -707,7 +707,7 @@
 
        /* create workqueue to handle packet allocations */
        if (workqueue_create(&sc->bnx_wq, device_xname(self),
-           bnx_alloc_pkts, sc, PRI_NONE, IPL_NET, WQ_MPSAFE) != 0) {
+           bnx_alloc_pkts, sc, PRI_NONE, IPL_NET, 0) != 0) {
                aprint_error_dev(self, "failed to create workqueue\n");
                goto bnx_attach_fail;
        }