[src/trunk]: src/lib/libpam/modules/pam_nologin Close file handle after using...

[wiz <wiz%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/5ad32a027913
branches:  trunk
changeset: 750885:5ad32a027913
user:      wiz <wiz%NetBSD.org@localhost>
date:      Sun Jan 17 23:17:08 2010 +0000

description:
Close file handle after using it. Found by cppcheck.

diffstat:

 lib/libpam/modules/pam_nologin/pam_nologin.c |  9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diffs (38 lines):

diff -r 637537d72344 -r 5ad32a027913 lib/libpam/modules/pam_nologin/pam_nologin.c
--- a/lib/libpam/modules/pam_nologin/pam_nologin.c      Sun Jan 17 23:13:32 2010 +0000
+++ b/lib/libpam/modules/pam_nologin/pam_nologin.c      Sun Jan 17 23:17:08 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pam_nologin.c,v 1.7 2008/01/27 01:23:20 christos Exp $ */
+/*     $NetBSD: pam_nologin.c,v 1.8 2010/01/17 23:17:08 wiz Exp $      */
 
 /*-
  * Copyright 2001 Mark R V Murray
@@ -40,7 +40,7 @@
 #ifdef __FreeBSD__
 __FBSDID("$FreeBSD: src/lib/libpam/modules/pam_nologin/pam_nologin.c,v 1.10 2002/04/12 22:27:21 des Exp $");
 #else
-__RCSID("$NetBSD: pam_nologin.c,v 1.7 2008/01/27 01:23:20 christos Exp $");
+__RCSID("$NetBSD: pam_nologin.c,v 1.8 2010/01/17 23:17:08 wiz Exp $");
 #endif
 
 
@@ -127,8 +127,10 @@
 
        PAM_LOG("Opened %s file", nologin);
 
-       if (fstat(fd, &st) < 0)
+       if (fstat(fd, &st) < 0) {
+               close(fd);
                return PAM_AUTH_ERR;
+       }
 
        mtmp = malloc(st.st_size + 1);
        if (mtmp != NULL) {
@@ -137,6 +139,7 @@
                pam_error(pamh, "%s", mtmp);
                free(mtmp);
        }
+       close(fd);
 
        PAM_VERBOSE_ERROR("Administrator refusing you: %s", nologin);