Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/hp700/dev Signal EOI correctly rather than deferenc...



details:   https://anonhg.NetBSD.org/src/rev/19411f9ba4a0
branches:  trunk
changeset: 749422:19411f9ba4a0
user:      skrll <skrll%NetBSD.org@localhost>
date:      Sun Nov 29 10:30:07 2009 +0000

description:
Signal EOI correctly rather than deferencing NULL.

diffstat:

 sys/arch/hp700/dev/apic.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (30 lines):

diff -r f17152b528a6 -r 19411f9ba4a0 sys/arch/hp700/dev/apic.c
--- a/sys/arch/hp700/dev/apic.c Sun Nov 29 10:17:01 2009 +0000
+++ b/sys/arch/hp700/dev/apic.c Sun Nov 29 10:30:07 2009 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: apic.c,v 1.3 2009/05/07 15:34:49 skrll Exp $   */
+/*     $NetBSD: apic.c,v 1.4 2009/11/29 10:30:07 skrll Exp $   */
 
 /*     $OpenBSD: apic.c,v 1.7 2007/10/06 23:50:54 krw Exp $    */
 
@@ -241,16 +241,14 @@
                if (iv->handler(iv->arg)) {
                        if (iv->cnt)
                                iv->cnt->ev_count++;
-                       else
-                               claimed = 1;
+                       /* Signal EOI. */
+                       elroy_write32(&r->apic_eoi,
+                           htole32((31 - APIC_INT_IRQ(iv->ih)) & APIC_ENT0_VEC));
+                       claimed = 1;
                }
                iv = iv->next;
        }
 
-       /* Signal EOI. */
-       elroy_write32(&r->apic_eoi,
-           htole32((31 - APIC_INT_IRQ(iv->ih)) & APIC_ENT0_VEC));
-
        return (claimed);
 }
 



Home | Main Index | Thread Index | Old Index