Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb remove debugging statements that have no chance ...



details:   https://anonhg.NetBSD.org/src/rev/790cb63fff29
branches:  trunk
changeset: 757877:790cb63fff29
user:      christos <christos%NetBSD.org@localhost>
date:      Fri Oct 01 17:02:35 2010 +0000

description:
remove debugging statements that have no chance of working (they crash)
since they are called from a context where we cannot log.

diffstat:

 sys/dev/usb/ucom.c |  14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)

diffs (58 lines):

diff -r e9b6f52d52c8 -r 790cb63fff29 sys/dev/usb/ucom.c
--- a/sys/dev/usb/ucom.c        Fri Oct 01 09:54:56 2010 +0000
+++ b/sys/dev/usb/ucom.c        Fri Oct 01 17:02:35 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ucom.c,v 1.83 2010/02/20 14:52:22 pooka Exp $  */
+/*     $NetBSD: ucom.c,v 1.84 2010/10/01 17:02:35 christos Exp $       */
 
 /*
  * Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.83 2010/02/20 14:52:22 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.84 2010/10/01 17:02:35 christos Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -982,10 +982,8 @@
                return;
 
        s = spltty();
-       if (ISSET(tp->t_state, TS_BUSY | TS_TIMEOUT | TS_TTSTOP)) {
-               DPRINTFN(4,("ucomstart: no go, state=0x%x\n", tp->t_state));
+       if (ISSET(tp->t_state, TS_BUSY | TS_TIMEOUT | TS_TTSTOP))
                goto out;
-       }
        if (sc->sc_tx_stopped)
                goto out;
 
@@ -996,10 +994,8 @@
        data = tp->t_outq.c_cf;
        cnt = ndqb(&tp->t_outq, 0);
 
-       if (cnt == 0) {
-               DPRINTF(("ucomstart: cnt==0\n"));
+       if (cnt == 0)
                goto out;
-       }
 
        ub = SIMPLEQ_FIRST(&sc->sc_obuff_free);
        KASSERT(ub != NULL);
@@ -1031,7 +1027,6 @@
 void
 ucomstop(struct tty *tp, int flag)
 {
-       DPRINTF(("ucomstop: flag=%d\n", flag));
 #if 0
        /*struct ucom_softc *sc =
            device_lookup_private(&ucom_cd, UCOMUNIT(dev));*/
@@ -1039,7 +1034,6 @@
 
        s = spltty();
        if (ISSET(tp->t_state, TS_BUSY)) {
-               DPRINTF(("ucomstop: XXX\n"));
                /* sc->sc_tx_stopped = 1; */
                if (!ISSET(tp->t_state, TS_TTSTOP))
                        SET(tp->t_state, TS_FLUSH);



Home | Main Index | Thread Index | Old Index